fix: App crash on back press to exit #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityastic @jddeep Please review. |
|
broadcast receivers should be registered and unregistered in onPause and onResume. Whatever did here is not the correct practice, please make the required changes. Thanks |
harshshinde07
force-pushed
the
backpresss
branch
from
34d5d9f to
c988d12
Compare
|
@adityastic I added |
|
@harshshinde07 registration should be done in onResume. So that the receivers only work when you are inside the app and stops as soon as you keep it in the background. We don't want to keep the receiver up when there is no app usage 👍 |
|
Registration should not have been done in onCreate in the first place, It's not your fault. It will be great if you can fix it :) |
harshshinde07
force-pushed
the
backpresss
branch
from
6c4fdb7 to
cfcc616
Compare
|
@adityastic Done :) |
jddeep
approved these changes
Nov 12, 2019
adityastic
approved these changes
Nov 15, 2019
|
@jddeep lets merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526
Changes:
Added try catch block to prevent the crash.
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
feature.zip