Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add zip in multiple network calls #2010

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@anhanh11001
Copy link
Contributor

anhanh11001 commented Jun 26, 2019

Details:

  • Add zip for flowable in multiple network calls for similar events
  • Make favorite button works in SimilarEvent list

Fixes: #2009

@auto-label auto-label bot added the feature label Jun 26, 2019
@anhanh11001 anhanh11001 requested a review from liveHarshit Jun 26, 2019
@liveHarshit liveHarshit dismissed their stale review Jun 26, 2019

wrong review

@anhanh11001 anhanh11001 requested review from iamareebjamal and removed request for iamareebjamal Jun 26, 2019
Copy link
Member

nikit19 left a comment

build fails.

@nikit19

This comment has been minimized.

Copy link
Member

nikit19 commented Jun 26, 2019

PR looks good. May be try re running the build

@anhanh11001

This comment has been minimized.

Copy link
Contributor Author

anhanh11001 commented Jun 26, 2019

@nikit19 updated. I just didn't know why build failed earlier. I basically changed nothing

@anhanh11001 anhanh11001 requested review from nikit19 and liveHarshit Jun 27, 2019
Details:
- Add zip for flowable in multiple network calls for similar events
- Make favorite button works in SimilarEvent list

Fixes: #2009
@iamareebjamal iamareebjamal dismissed stale reviews from nikit19 and themself Jun 28, 2019

stale

@iamareebjamal iamareebjamal merged commit b190244 into fossasia:development Jun 28, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mergeable Mergeable Run has been Completed!
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@anhanh11001 anhanh11001 deleted the anhanh11001:2009_zip_rxjava branch Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.