Skip to content

Conversation

yashk2000
Copy link
Member

Fixed #2797

Changes: Attempt to fix the auto release script.

@auto-label auto-label bot added the chore label Jun 30, 2019
@yashk2000
Copy link
Member Author

@iamareebjamal please review.

Copy link
Member

@liveHarshit liveHarshit Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 26.0.3 should replace with $ANDROID_BUILD_TOOLS_VERSION to solve the directory not found Travis error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liveHarshit ok. But I do not understand how it makes a difference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build tool version is different, in Travis script it is ANDROID_BUILD_TOOLS_VERSION=25.0.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test it by running the full script, and exit before the release commands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liveHarshit sorry for the delay in response. Thanks for the help. I'll try updating the ANDROID_BUILD_TOOLS_VERSION to 28.0.3 and then running the script.

@yashk2000
Copy link
Member Author

@liveHarshit @iamareebjamal is this fine?

@iamareebjamal iamareebjamal changed the base branch from development to master July 1, 2019 16:30
@iamareebjamal iamareebjamal merged commit 03a3ec3 into fossasia:master Jul 1, 2019
@yashk2000
Copy link
Member Author

@iamareebjamal this commit got merged with master by mistake. Can we revert it?

@iamareebjamal
Copy link
Member

It was deliberate

pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants