-
Notifications
You must be signed in to change notification settings - Fork 914
chore: Fixed auto-release script #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@iamareebjamal please review. |
scripts/update-apk.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 26.0.3 should replace with $ANDROID_BUILD_TOOLS_VERSION
to solve the directory not found
Travis error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liveHarshit ok. But I do not understand how it makes a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the build tool version is different, in Travis script it is ANDROID_BUILD_TOOLS_VERSION=25.0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just test it by running the full script, and exit before the release commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liveHarshit sorry for the delay in response. Thanks for the help. I'll try updating the ANDROID_BUILD_TOOLS_VERSION
to 28.0.3
and then running the script.
@liveHarshit @iamareebjamal is this fine? |
@iamareebjamal this commit got merged with master by mistake. Can we revert it? |
It was deliberate |
Fixed #2797
Changes: Attempt to fix the auto release script.