Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signup option #268

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Add signup option #268

merged 1 commit into from
Jan 12, 2018

Conversation

ms10398
Copy link
Member

@ms10398 ms10398 commented Jan 11, 2018

Fixes #230

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added option of signup from the chromebot

Screenshot

screenshot from 2018-01-11 10-24-59
screenshot from 2018-01-11 10-24-19

src/signup.html Outdated
<button type="submit" class="btn btn-success" id="signupbutton">Signup</button>
<br>
<p style="text-align: center;">
<a href="login.html" style="color: #fff; ">Already Registered?Want to Login</a>
Copy link
Member

@sansyrox sansyrox Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a space between "?" or add a br tag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check it now @stealthanthrax

@ms10398
Copy link
Member Author

ms10398 commented Jan 11, 2018

Check out now @stealthanthrax @0x48piraj @sachincool @gabru-md

Copy link
Member

@0x48piraj 0x48piraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work !!
LGTM !! 🎉

src/js/signup.js Outdated
success: function (response) {
if(response.accepted){
alert(response.message);
console.log(response);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console log

Add signup option

Add signup option
@ms10398
Copy link
Member Author

ms10398 commented Jan 12, 2018

@gabru-md Have a look again

@ms10398 ms10398 merged commit 492c77c into fossasia:master Jan 12, 2018
@ms10398 ms10398 deleted the signup branch January 12, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to signup from the chromebot
5 participants