Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added eye feature in change password form #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added eye feature in change password form #500

wants to merge 1 commit into from

Conversation

samagragupta
Copy link
Member

@samagragupta samagragupta commented Dec 8, 2018 •
edited
Loading

Fixes #466

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

eye
eye

Changes proposed in this pull request:

Added eye in the password fields

rupav
rupav reviewed Dec 8, 2018
View reviewed changes
Copy link
Member

@rupav rupav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some gifs to show the working of it?

@samagragupta
Copy link
Member Author

@rupav Uploaded the gif

rupav
rupav approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@rupav rupav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neeraj3029
neeraj3029 approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@neeraj3029 neeraj3029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@samagragupta
Copy link
Member Author

@gabru-md @hkedia321 Please review.

championpaddler
championpaddler approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@championpaddler championpaddler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fragm3
fragm3 requested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using 3 addEventListener, create a function to do so

@samagragupta
Copy link
Member Author

@fragm3 There is no need of a function as there would event Listener for every eye.

fragm3
fragm3 requested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samagragupta you can simply loop over an array to achieve the same thing. Look into this

@samagragupta
Copy link
Member Author

@ms10398 @hkedia321 Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fragm3 fragm3 fragm3 requested changes

@neeraj3029 neeraj3029 neeraj3029 approved these changes

@rupav rupav rupav approved these changes

@hkedia321 hkedia321 hkedia321 approved these changes

@championpaddler championpaddler championpaddler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eye feature in change password form
6 participants
@samagragupta @championpaddler @hkedia321 @fragm3 @rupav @neeraj3029