Skip to content

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Sep 16, 2025

Pinning hashes for dependencies in workflows is a security best practice

Excluded from pinning are actions from the github/* and actions/* given that these are officially managed by Github and are not raised by zizmor

By configuring dependabot with package-ecosystem: "github-actions" it will open a pull request only for updating pinned hashes (not cargo, etc..): https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#enabling-dependabot-version-updates-for-actions

The <hash> #<branch_name> syntax is what dependabot picks up on

Note: foundry-toolchain@v1 has been left unpinned as it will help us catch issues more easily and it is in our interest to be up to date. Let me know if this makes sense @grandizzy or if we should pin instead.

@zerosnacks zerosnacks marked this pull request as ready for review September 16, 2025 10:23
Copy link
Contributor

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zerosnacks
Copy link
Member Author

Temporarily moving back to draft, some specific handling is required for dependabot to work

@zerosnacks zerosnacks marked this pull request as draft September 16, 2025 11:13
@zerosnacks zerosnacks marked this pull request as ready for review September 16, 2025 11:28
@zerosnacks zerosnacks merged commit 0e01ca7 into master Sep 16, 2025
25 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/add-default-permissions-block branch September 16, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants