chore(ci): clean up workflow + harden workflow by setting default permission to read only
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Sep 15, 2025
Comment on lines
-34
to
-40
| - name: Install Anvil | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| version: nightly | ||
| - name: Install test binaries | ||
| shell: bash | ||
| run: ./.github/scripts/install_test_binaries.sh |
zerosnacks
commented
Sep 15, 2025
Comment on lines
-67
to
-80
| no-std: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| target: riscv32imac-unknown-none-elf | ||
| - uses: taiki-e/install-action@cargo-hack | ||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-on-failure: true | ||
| - name: check | ||
| run: ./scripts/check_no_std.sh |
There was a problem hiding this comment.
note: drops explicit no-std requirement per discussion
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
onbjerg and
0xrusowsky
as code owners
auto-merge was automatically disabled
September 15, 2025 10:28
Pull request was converted to draft
zerosnacks
changed the title
ci): clean up workflow + harden workflow by setting permissions per jobci): clean up workflow + harden workflow by setting default permission to read only
onbjerg
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines per action permissions scoping, defaulting to read only
RE:
See: actions/checkout#485
This does not yet introduce pinning to hashes, I want to find a good way to maintain this first. Apparently Dependabot has a feature for this.
Updates the workflow to no longer install redundant Anvil and Geth installations