chore(lint): use solar's built-in code suggestions #11919
Merged
+775
−676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrusowsky
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks and
onbjerg
as code owners
onbjerg
requested changes
Oct 2, 2025
…ndry into rusowsky/diag-suggestions
onbjerg
reviewed
Oct 2, 2025
Co-authored-by: onbjerg <onbjerg@users.noreply.github.com>
Co-authored-by: onbjerg <onbjerg@users.noreply.github.com>
onbjerg
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
now that solar v0.1.8 has been released, we can use solar's built-in code suggestion rather than having to manually handle that.
closes #11582
Solution
Snippetin favor of a new typeSuggestionfn emit_with_fix()to use the new solar APIadditionally, i added inline suggestions for naming-related lints
PR Checklist