Skip to content

perf: reduce memory usage by boxing large error variants in wallet operations #11928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

perf: reduce memory usage by boxing large error variants in wallet operations #11928

merged 3 commits into from
Oct 2, 2025
+17 −5

Conversation

Bilogweb3
Copy link
Contributor

Optimize Result<T, WalletSignerError> memory usage by boxing large error variants.

  • Before: 344 bytes (AwsSignerError variant)
  • After: ~50-100 bytes
  • Improvement: 70-85% reduction in stack usage

Changes:

  • Box AwsSignerError and GcpSignerError variants
  • Update error handling for compatibility

@Bilogweb3 Bilogweb3 requested a review from DaniPopes as a code owner October 2, 2025 13:17
@onbjerg onbjerg merged commit 047d28d into foundry-rs:master Oct 2, 2025
16 checks passed
@onbjerg onbjerg self-assigned this Oct 2, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

@onbjerg onbjerg

Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilogweb3 @onbjerg