Skip to content

fix(forge): replay fuzz failure only if same test selector #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix(forge): replay fuzz failure only if same test selector #11947

merged 1 commit into from
Oct 3, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Oct 3, 2025 •
edited
Loading

Motivation

Solution

  • do not replay failure if current test selector is different than test that created counterexample
  • extra: replayed failure does not count as a run, so if logic changes to vm.assume then should not decrement total runs

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy added this to the v1.4.0 milestone Oct 3, 2025
@grandizzy grandizzy changed the title fix(forge): replay fuzz failure only if same test sig fix(forge): replay fuzz failure only if same test selector Oct 3, 2025
@grandizzy grandizzy marked this pull request as ready for review October 3, 2025 11:40
yash-atreya
yash-atreya approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@grandizzy grandizzy merged commit 7b84375 into foundry-rs:master Oct 3, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 3, 2025
@grandizzy grandizzy deleted the issue-11927 branch October 3, 2025 11:56
grandizzy added a commit to grandizzy/foundry that referenced this pull request Oct 3, 2025
@grandizzy
fix(forge): replay fuzz failure only if same test selector (foundry-r…
778bc22 
…s#11947)
@grandizzy grandizzy mentioned this pull request Oct 3, 2025
Merged
3 tasks
grandizzy added a commit that referenced this pull request Oct 3, 2025
@grandizzy
fix(forge): 1.4 backport replay fuzz failure only if same test select…
0fa4aef 
…or (#11947) (#11949)

fix(forge): replay fuzz failure only if same test selector (#11947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

bug(fuzz): replay fails for counterexample recorded with different test selector
2 participants
@grandizzy @yash-atreya