Skip to content

chore(npm): remove unused ArchitecturePlatform export from const.ts #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore(npm): remove unused ArchitecturePlatform export from const.ts #11954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e479034
Update install.ts
anim001k Oct 3, 2025
614cef8
Update const.ts
anim001k Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions npm/src/const.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ export type Platform = Extract<
'darwin' | 'linux' | 'win32'
>

/**
* foundry doesn't ship arm64 binaries for windows
*/
export type ArchitecturePlatform = Exclude<
`${Platform}-${Architecture}`,
'win32-arm64'
>
// Note: we intentionally don't export a combined `Platform-Architecture` alias here,
// since only specific pairs are supported (see `BINARY_DISTRIBUTION_PACKAGES`).

export const BINARY_DISTRIBUTION_PACKAGES = {
darwin: {
Expand Down
2 changes: 1 addition & 1 deletion npm/src/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function extractFileFromTarball(
if (fileName === filepath)
return tarballBuffer.subarray(offset, offset + fileSize)

// Clamp offset to the uppoer multiple of 512
// Clamp offset to the upper multiple of 512
offset = (offset + fileSize + 511) & ~511
}
throw new Error(`File ${filepath} not found in tarball`)
Expand Down
Loading