Skip to content

feat(chisel): use immutable borrow in Debug for SolidityHelper #11957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(chisel): use immutable borrow in Debug for SolidityHelper #11957

wants to merge 1 commit into from

Conversation

MozirDmitriy
Copy link
Contributor

Replace RefCell::borrow_mut() with borrow() in Debug impl.
Benefits:

  • Avoids unnecessary exclusive borrow during formatting.
  • Eliminates potential runtime panic if a shared borrow is active.
  • Matches Debug’s non-mutating intent and improves robustness with Rc<RefCell<...>>.

DaniPopes added a commit that referenced this pull request Oct 3, 2025
@DaniPopes
chore: aggregate PRs
f7cbdfd 
This PR aggregates changes from the following PRs:

- Closes #11957 by @\MozirDmitriy
- Closes #11954 by @\anim001k
- Closes #11953 by @\strmfos
- Closes #11939 by @\silvekkk
@DaniPopes DaniPopes mentioned this pull request Oct 3, 2025
Closed
DaniPopes added a commit that referenced this pull request Oct 3, 2025
@DaniPopes
chore: aggregate PRs
25bbe5a 
This PR aggregates changes from the following PRs:

- Closes #11957 by @\MozirDmitriy
- Closes #11954 by @\anim001k
- Closes #11953 by @\strmfos
- Closes #11939 by @\silvekkk
DaniPopes added a commit that referenced this pull request Oct 3, 2025
@DaniPopes
chore: aggregate PRs
bf3db9d 
This PR aggregates changes from the following PRs:

- Closes #11957 by @\MozirDmitriy
- Closes #11954 by @\anim001k
- Closes #11953 by @\strmfos
@DaniPopes DaniPopes mentioned this pull request Oct 3, 2025
Merged
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 3, 2025
pull bot pushed a commit to Getitboy9/foundry that referenced this pull request Oct 3, 2025
@DaniPopes
chore: aggregate PRs (foundry-rs#11959)
b7d4970 
This PR aggregates changes from the following PRs:

- Closes foundry-rs#11957 by @\MozirDmitriy
- Closes foundry-rs#11954 by @\anim001k
- Closes foundry-rs#11953 by @\strmfos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MozirDmitriy