feat(forge): add flag to disable HTTPS certificate validation for RPC #11960
+44
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
reviewed
Oct 3, 2025
There was a problem hiding this comment.
Nice, but I guess it would be actually cleaner to build the provider using :
foundry/crates/cli/src/utils/mod.rs
Lines 102 to 106 in c646b88
this would retrieve eth_rpc_accept_invalid_certs key from the config directly.
This actually confirms the need for a refactor of the RpcOpts/EvmArgs common fields. So I'll open a dedicated issue to get feedback from the project team.
| #[track_caller] | ||
| pub fn get_http_provider(builder: impl AsRef<str>) -> RetryProvider { | ||
| try_get_http_provider(builder).unwrap() | ||
| pub fn get_http_provider(builder: impl AsRef<str>, accept_invalid_certs: bool) -> RetryProvider { |
| let Some(endpoint) = ENDPOINT else { return }; | ||
|
|
||
| let provider = get_http_provider(endpoint); | ||
| let provider = get_http_provider(endpoint, false); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #11907 (comment).
Solution
--insecure/-kflag toforge scriptwhich toggles ignoring invalid certs (e.g., self-signed)I'm not sure this PR handles all possible codepaths as new providers are built in many different places and each needs to be configured with
.accept_invalid_certs(bool).PR Checklist