Skip to content

fix: correct version suffix for rc builds #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix: correct version suffix for rc builds #11961

merged 1 commit into from
Oct 3, 2025

Conversation

0xferrous
Copy link
Contributor

Motivation

wrong output on latest rc:

$ forge --version
forge Version: 1.4.0-v1.4.0-rc2
Commit SHA: 0fa4aef9e1fc26c7e62d6337de3b964e02b6ae1e
Build Timestamp: 2025-10-03T13:52:39.653356707Z (1759499559)
Build Profile: maxperf

Solution

better formatting

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@0xferrous
Copy link
Contributor Author 

$ TAG_NAME="v1.4.0-rc2" cargo b; ./target/debug/forge --version
forge Version: 1.4.0-rc2
Commit SHA: 793d824bcc4890b80b811ba62212c237c0ffc607
Build Timestamp: 2025-10-03T20:00:09.669265238Z (1759521609)
Build Profile: debug

onbjerg
onbjerg requested changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just use split_once

@onbjerg onbjerg self-assigned this Oct 3, 2025
onbjerg
onbjerg approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@onbjerg onbjerg enabled auto-merge (squash) October 3, 2025 21:45
@onbjerg onbjerg merged commit e4c6951 into foundry-rs:master Oct 3, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

@onbjerg onbjerg

Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xferrous @onbjerg