Skip to content

perf: improve artifact handling in create #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2022
Merged

perf: improve artifact handling in create #2072

merged 4 commits into from
Jun 30, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jun 22, 2022 •
edited
Loading

Motivation

Blocked by gakonst/ethers-rs#1406

Instead of reading the cache file, get te contract from the project's compiler output

Closes #1972

Solution

get the contract artifact directly from the compiler output

@mattsse mattsse added Cmd-forge-create Command: forge create T-perf Type: performance labels Jun 22, 2022
@mattsse mattsse mentioned this pull request Jun 22, 2022
Merged
3 tasks
@mattsse mattsse marked this pull request as ready for review June 30, 2022 17:46
@gakonst gakonst merged commit d000eec into foundry-rs:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
Cmd-forge-create Command: forge create T-perf Type: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf: improve forge create artifact handling
2 participants
@mattsse @gakonst