Reject prompts of several properties when an item has no activation type #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `uses.per` is not set. Also adds 'None' to the `select`.
if no activation type or no target or type set
type is not set
|
Marking this as blocked on #2387 for now |
Fyorl
approved these changes
Oct 19, 2023
56 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #2288, #2286, #2285.
The
isActivegetter returns whether an activation type is set in an item.With this, if an item's Activation Type is set to 'None' (which also hides limited uses, recharge, resource consumption in the item sheet), their respective prompts will no longer be forced. I.e., an item can be "used" with activation type "none" and uses/target/recharge/consume filled in, but no prompts will be made.
Taken the liberty of cleaning up some labels on the actor sheet as well, since those were related.