-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#986] Allow for rotating a square/cube template #2425
Conversation
A good change but let's add a system setting to allow DMs to have the old behaviour and prevent players from being able to rotate square templates since that is apparently a preference some DMs have. |
Done so. I feel it's fair to prevent it, but the default should be to allow it (going by the discussion in #986), so I have set the setting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I think we should lend some weight to maintaining the status quo here so that there are no surprises when people update, but I don't feel that strongly.
@krbz999 I've made a change that I hope is a reasonable compromise. The setting is now renamed to frame it as opt-in to prevent square templates from being rotated. The setting is on by default however as that matches the system's previous behaviour, so this way it's a smoother migration path. If you feel very strongly, we can discuss and perhaps revert the commit on your branch, but otherwise hopefully we can proceed. |
Fine by me. Yeet. |
It is now hip to be square.
Ideally the ability to rotate a rectangle without changing its height or width would be a core improvement. However given that the system can neither rotate properly while placing it, nor afterwards, setting squares and cubes to be equal-side ray templates is a good solution in the meantime.
Closes #986