Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#986] Allow for rotating a square/cube template #2425

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

krbz999
Copy link
Contributor

@krbz999 krbz999 commented Aug 12, 2023

It is now hip to be square.

Ideally the ability to rotate a rectangle without changing its height or width would be a core improvement. However given that the system can neither rotate properly while placing it, nor afterwards, setting squares and cubes to be equal-side ray templates is a good solution in the meantime.

Closes #986

@krbz999 krbz999 changed the base branch from master to 2.4.x October 20, 2023 19:40
@Fyorl
Copy link
Contributor

Fyorl commented Oct 23, 2023

A good change but let's add a system setting to allow DMs to have the old behaviour and prevent players from being able to rotate square templates since that is apparently a preference some DMs have.

@krbz999
Copy link
Contributor Author

krbz999 commented Oct 23, 2023

Done so. I feel it's fair to prevent it, but the default should be to allow it (going by the discussion in #986), so I have set the setting to default: true.

Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I think we should lend some weight to maintaining the status quo here so that there are no surprises when people update, but I don't feel that strongly.

@arbron arbron added this to the D&D5E 2.4.0 milestone Nov 1, 2023
@Fyorl
Copy link
Contributor

Fyorl commented Nov 6, 2023

@krbz999 I've made a change that I hope is a reasonable compromise. The setting is now renamed to frame it as opt-in to prevent square templates from being rotated. The setting is on by default however as that matches the system's previous behaviour, so this way it's a smoother migration path.

If you feel very strongly, we can discuss and perhaps revert the commit on your branch, but otherwise hopefully we can proceed.

@krbz999
Copy link
Contributor Author

krbz999 commented Nov 6, 2023

Fine by me. Yeet.

@Fyorl Fyorl merged commit d64f837 into foundryvtt:2.4.x Nov 6, 2023
@krbz999 krbz999 deleted the rotate-squares branch November 7, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting a square/cube spell creates a measured template of the wrong type
3 participants