Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#342] Change race to apply senses & movement dynamically #2584

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Nov 14, 2023

Allows values and units on movement & senses to be null. Any null values will be replaced by data in race if a character has one.

Adds a migration that modifies any 0s in those fields to null, as long as the actor hasn't already been changed for 2.4.0 based on the built-in _stats. This will allow those fields to be explicitly set to 0 without the risk of being clobbered in future migrations.

@arbron arbron requested a review from Fyorl November 14, 2023 15:43
@arbron arbron self-assigned this Nov 14, 2023
@arbron arbron added this to the D&D5E 2.4.0 milestone Nov 14, 2023
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, thanks for doing this work, Jeff. I had one point of discussion about inheriting creature type. It would be good to decide now before we release as it will be harder to change later.

module/data/item/race.mjs Outdated Show resolved Hide resolved
module/migration.mjs Outdated Show resolved Hide resolved
@arbron
Copy link
Collaborator Author

arbron commented Nov 14, 2023

@Fyorl I've made it so type is only defined by race, and I've linked the configure button on the character sheet so it edits the value directly on the race item, so it is still easy to modify.

@arbron arbron requested a review from Fyorl November 14, 2023 17:50
templates/apps/actor-type.hbs Outdated Show resolved Hide resolved
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this work is coming together nicely, thanks Jeff

@arbron arbron merged commit 170cc55 into foundryvtt:2.4.x Nov 14, 2023
@arbron arbron deleted the types/race-derive branch November 14, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants