-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#342] Change race to apply senses & movement dynamically #2584
Conversation
14f2447
to
0f23779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, thanks for doing this work, Jeff. I had one point of discussion about inheriting creature type. It would be good to decide now before we release as it will be harder to change later.
4ca8e65
to
52ea62b
Compare
@Fyorl I've made it so type is only defined by race, and I've linked the configure button on the character sheet so it edits the value directly on the race item, so it is still easy to modify. |
52ea62b
to
132ad98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this work is coming together nicely, thanks Jeff
Allows values and units on movement & senses to be
null
. Anynull
values will be replaced by data in race if a character has one.Adds a migration that modifies any
0
s in those fields tonull
, as long as the actor hasn't already been changed for2.4.0
based on the built-in_stats
. This will allow those fields to be explicitly set to0
without the risk of being clobbered in future migrations.