Make work with Vue 3 #124
Merged
Make work with Vue 3 #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update version of Vue used for testing to Vue 3 -- Vue 2 is no longer being tested, but it should work - Switch to vitest ; Vue 3 cannot instantiate a component without mounting it so need a DOM library. I couldn't quite get one working with tape, so decided to switch to vitest
cdrini
force-pushed
the
feature/vue-3-compat
branch
from
7996288 to
883e33a
Compare
|
Updated description: Switched this to making it Vue 3 only and used the proper mount listeners instead of the internal state handlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
I've gotten all the tests working with Vue 3!
Notes:
tapetovitestsince Vue 3 cannot instantiate a component without mounting it so need a Node DOM library. I couldn't quite get one working with tape, so decided to switch to vitestisDestroyedhandler.Remaining steps:
Do a real-world Vue 3 test ; I've only looked at the unit testsWorked like a charm in a demo project! The types could use some love to match the types in egcomputed, but considering out of scope for this PR.