cpp: fix readMessages() for empty file #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
approved these changes
Jul 21, 2022
jtbandes
added a commit
to ros-tooling/rosbag2_storage_mcap
that referenced
this pull request
Jul 22, 2022
Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482 Signed-off-by: James Smith <james@foxglove.dev>
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 18, 2022
…e_mcap#42) Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482 Signed-off-by: James Smith <james@foxglove.dev>
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 18, 2022
…ge_mcap#42) Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482 Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Fixed
McapReader::readMessages()so it doesn't produce an invalid reference when reading an empty file.Description
We do this
if (!impl_->has_value()) impl_ = nullptrdance after eachLinearMessageView::Iterator::operator++(), but we forgot to do it at the beginning.