Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector-0.12.0.0 #2194

Closed
69 of 86 tasks
juhp opened this issue Jan 8, 2017 · 35 comments
Closed
69 of 86 tasks

vector-0.12.0.0 #2194

juhp opened this issue Jan 8, 2017 · 35 comments
Labels
failure: bounds

Comments

@juhp
Copy link
Contributor

juhp commented Jan 8, 2017 •
edited
Loading

vector-0.12.0.0 is out of bounds for:

Due to the large number of packages initially affected, there is no need to post update comments at this stage.
@juhp juhp mentioned this issue Jan 8, 2017
Closed
juhp added a commit that referenced this issue Jan 8, 2017
@juhp
vector < 0.12.0.0 (#2194)
1f6b705
@Gabriella439
Copy link
Contributor

foldl-1.2.3 is fixed

@ocharles
Copy link
Contributor

ocharles commented Jan 8, 2017

Due to the large number of packages initially affected, there is no need to post update comments at this stage.

@RyanGlScott
Copy link
Contributor

Since Stackage doesn't seem to record this info: the maintainer of vector-algorithms is @dolio. And since vector-algorithms doesn't use git: I have a patch which revises the upper version bounds on vector here.

tfausak added a commit to tfausak/rattletrap that referenced this issue Jan 8, 2017
@tfausak
Allow vector 0.12.0.0
7051257 
commercialhaskell/stackage#2194
@byorgey byorgey mentioned this issue Jan 8, 2017
Closed
@juhp
Copy link
Contributor Author

juhp commented Jan 9, 2017 •
edited
Loading

(Having said that, personally as maintianer I find the update comments really useful, but of course many people will get notified via github.)

I suspect people can't update the checkboxes in my original comment?

@mdibaiee
Copy link
Contributor

mdibaiee commented Jan 9, 2017 •
edited
Loading

@juhp No, at least I can't. AFAIK only collaborators can edit/update comments.

Now that I have a comment: sibe-0.2.0.4 is fixed. Waiting on JuicyPixels to fix picedit.

Update: picedit-0.1.1.2 is fixed, too.

@axman6
Copy link
Contributor

axman6 commented Jan 9, 2017 •
edited
Loading

@juhp Correct. Not sure if it's possible to allow others to update the description of the issue without making them members of the project sadly.

I believe I've made the necessary changes in foldl-statistics-0.1.4.2, and given Gabriel's update to foldl, I think these should both be fixed now. (Thanks @Gabriel439 for the quick fix).

Also, it appears vector-binary-instances has also been updated (an indirect dependency of my package).

@Twinside
Copy link
Contributor

Twinside commented Jan 9, 2017

@mdibaiee I've updated JuicyPixels' bounds on hackage (no need to make a new release), it compiles with Vector 0.12

@MichelBoucey
Copy link
Contributor

cayley-client fixed.

@mrkkrp
Copy link
Contributor

mrkkrp commented Jan 9, 2017

Since we comment anyway: cassava-megaparsec, flac and stache fixed.

@juhp
Copy link
Contributor Author

juhp commented Jan 9, 2017

Thank you for all the Hackage updates: I have refreshed the initial comment.

@phadej phadej mentioned this issue Jan 9, 2017
Closed
2 tasks
@paulrzcz
Copy link
Contributor

hquantlib fixed but it requires packages scientific and integer-logarithms to bump their versions too.

@phadej
Copy link
Contributor

phadej commented Jan 10, 2017 •
edited
Loading

@paulrzcz AFAIK neither scientific or integer-logarithms depend on vector? Maybe you are missinterpretting something (they depend thru criterion, which depends on cassava).

Generally, I hope that people actually test that their package is compiled against vector-0.12, e.g. there is no way to compile cassava-megaparsec against vector-0.12 without using --allow-never. Hopefully @mrkkrp did so. (cassava in fact seems to compile fine with vector-0.12).

EDIT: the dependency graph of the libraries might be helpful in such big issues, there is no much one can do as a package maintainer of some leaf package (which happens to have direct dependency as well).

@paulrzcz
Copy link
Contributor

@phadej After raising the vector version to 0.12.0.0 in extra-deps of stack.yaml and rebuilding the project with stack against Stackage LTS 7.15, I've got:

Error: While constructing the build plan, the following exceptions were encountered:

In the dependencies for scientific-0.3.4.9:
    vector-0.12.0.0 must match >=0.7 && <0.12 (latest applicable is 0.11.0.0)
needed due to hquantlib-0.0.3.4 -> scientific-0.3.4.9

In the dependencies for vector-binary-instances-0.2.3.3:
    vector-0.12.0.0 must match >=0.6 && <0.12 (latest applicable is 0.11.0.0)
needed due to hquantlib-0.0.3.4 -> vector-binary-instances-0.2.3.3

Plan construction failed.

Bumping of scientific to version 0.3.4.10 came up with integer-logarithm:

In the dependencies for scientific-0.3.4.10:
    integer-logarithms must match >=1 && <1.1, but the stack configuration has no specified version
                       (latest applicable is 1)
needed due to hquantlib-0.0.3.4 -> scientific-0.3.4.10

The next step is to add interger-logarithms-1. So now hquantlib is buildable and has got extra-deps:

extra-deps:
 - vector-0.12.0.0
 - vector-binary-instances-0.2.3.4
 - scientific-0.3.4.10
 - integer-logarithms-1

Studying the full dependency graph shows that scientific come from aeson-0.11.2.1 package and takes integer-logarithms with it. vector-binary-instances are direct dep of statistics.

Though, it builds without additional version bumps against Stackage nightly-2017-01-10 that already includes those versions of packages, except vector-0.12.0.0.

@phadej
Copy link
Contributor

phadej commented Jan 10, 2017

@paulrzcz few things: use solver, e.g. stack solver, or cabal

hquantlib-0.0.3.3 master % git diff
diff --git a/hquantlib.cabal b/hquantlib.cabal
index a9deb2d..3885d56 100644
--- a/hquantlib.cabal
+++ b/hquantlib.cabal
@@ -72,7 +72,7 @@ library
                         parallel        >= 3.2.0.0      && < 3.3.0.0,
                         mersenne-random >= 1.0.0.1      && < 2.0.0.0,
                         statistics      >= 0.13.0.0     && < 0.14.0.0,
-                        vector          >= 0.11.0.0     && < 0.12.0.0,
+                        vector          >= 0.11.0.0     && < 0.13.0.0,
                         vector-algorithms >= 0.7.0.0    && < 0.8.0.0
 
         hs-source-dirs: src
[FL973] ~/mess/hquantlib-0.0.3.3 master % cabal new-build --only-dependencies --dry-run --constraint vector==0.12.0.0 --enable-tests|tail
 - storable-complex-0.2.2 (lib:storable-complex) (requires download & build)
 - vector-algorithms-0.7.0.1 (lib) (requires build)
 - vector-th-unbox-0.2.1.6 (lib) (requires build)
 - monad-par-extras-0.3.3 (lib) (requires build)
 - hmatrix-0.18.0.0 (lib) (requires download & build)
 - math-functions-0.2.1.0 (lib) (requires download & build)
 - monad-par-0.3.4.8 (lib) (requires build)
 - hmatrix-gsl-0.18.0.1 (lib) +onlygsl (requires download & build)
 - statistics-0.13.3.0 (lib) (requires build)
 - hmatrix-special-0.4.0.1 (lib:hmatrix-special) (requires download & build)

It's not visible in the output, but for vector-0.12 one need to pick scientific-0.3.4.10 and vector-binary-instances-0.2.3.4, and maybe some other ripples.

Another thing, I noticed in hquantlib:

mersenne-random >= 1.0.0.1      && < 2.0.0.0

But 2.0 < 2.0.0.0 holds. It's unfortunate legacy quirk (and hopefully cabal check will say about it, cc @hvr)

@fosskers
Copy link
Contributor

vectortiles updated.

@hadronized
Copy link
Contributor

smoothie updated.

@bergmark
Copy link
Member

New entry:

@bitemyapp bitemyapp mentioned this issue Jan 30, 2017
Closed
@phadej
Copy link
Contributor

phadej commented Jan 30, 2017 •
edited
Loading

folds bound relaxed, also binary-tagged

@fhaust fhaust mentioned this issue Jan 31, 2017
Closed
@bergmark
Copy link
Member

These mentions were originally truncated: @NicolasT @codedmart @tmcgilchrist @acid-state @jtobin @polarina @isomorphism @klao @nilcons @bgmari @mstksg @expipiplusx @fhaust @mgajda

@bergmark
Copy link
Member

@bgamari *

@phadej
Copy link
Contributor

phadej commented Jan 31, 2017

these is updated though already ;) (the isomorphism's ping)

@fhaust
Copy link
Contributor

fhaust commented Jan 31, 2017

vector-split updated

@polarina
Copy link
Contributor

sdl2 has been updated.

@NicolasT
Copy link
Contributor

Whilst my package compiles nicely with vector-0.12.0.0, a change of behaviour in the vector package causes breakage. I hope this can be resolved within vector (as I wouldn't be surprised other code could be broken because of this change as well): haskell/vector#152

@jtobin
Copy link
Contributor

jtobin commented Jan 31, 2017

sampling-0.3.2 is fixed.

@mstksg mstksg mentioned this issue Feb 1, 2017
Merged
@phadej
Copy link
Contributor

phadej commented Feb 1, 2017

tz and tzdata updated.

@mstksg
Copy link
Contributor

mstksg commented Feb 3, 2017

vector-sized with fix pushed to hackage

@byorgey byorgey mentioned this issue Feb 6, 2017
Merged
@DanBurton
Copy link
Contributor

LTS 8 will be released soon, probably with vector-0.11.0.0.

After the LTS 8.0 release, the packages listed below (and any that depend on them) will continue to be included in LTS 8 builds, but will be dropped from nightly builds until a release compatible with vector-0.12.0.0 is made available.

@bitemyapp
Copy link
Contributor

@DanBurton we've got a release coming soon that already fixes the vector bump and can easily fix the hspec bump, we're just doing some house cleaning before-hand because it's a big change for unrelated-to-Stackage reasons.

@timbod7
Copy link

timbod7 commented Feb 11, 2017

Chart-1.8.2 uploaded.

@hadronized
Copy link
Contributor

I’m updating wavefront. Is that too late? :D

@bitemyapp
Copy link
Contributor

bloodhound-0.13.0.0 is released with vector-0.12.0.0 compatibility.

@typedrat
Copy link
Contributor

stb-image-redux is now vector-0.12.0.0 compatible.

@byorgey
Copy link
Contributor

byorgey commented Mar 29, 2017

I just pinged @gregorycollins again and he made a new release of hashtables that supports vector-0.12. I think this may unblock a large number of packages that are currently excluded. @DanBurton ?

(Also, I updated diagrams-cairo which was blocked on hashtables.)

@juhp
Copy link
Contributor Author

juhp commented Mar 29, 2017

Thanks a lot, @byorgey, for the update! Very helpful

juhp added a commit that referenced this issue Mar 29, 2017
@juhp
reenable hashtables! (see #2194)
c0a605d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failure: bounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests