Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Control.Monad.unless #50

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Import Control.Monad.unless #50

merged 1 commit into from
Jun 21, 2023

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Apr 21, 2023

This is necessary for GHC 9.6 compatibility. I ran the tests on GHC 9.6.1, they pass.

Fixes #49

@ysangkok
Copy link
Contributor Author

@chrisdone If you have the time, a review would be much appreciated!

@mrkkrp
Copy link

mrkkrp commented Jun 20, 2023

I don't think this is going to advance. The last commit to this repo was in 2020, @chrisdone is not exactly active these days and he is not at FP complete anymore. I'm pondering myself how to unblock my packages that depend on weigh.

@psibi psibi merged commit 44e7045 into fpco:master Jun 21, 2023
@psibi
Copy link
Member

psibi commented Jun 21, 2023

I will see if I can do a release once I get hackage access. Sorry for the delay.

@chrisdone-artificial
Copy link

This one slipped between the cracks. I'll make sure psibi is added as maintainer now.

@chrisdone-artificial
Copy link

chrisdone-artificial commented Jun 21, 2023

OK, I've added both @psibi and @snoyberg.

I am actually using weigh at my current workplace.

BTW, I think sometimes you can ping multiple times an author in case you just missed them the first time. I was moving house to another city in April, for example. (There's a load of bureaucratic work involved with that which can take precedent over open source contributions.)

@ysangkok ysangkok deleted the janus/import-unless branch June 21, 2023 07:57
@psibi
Copy link
Member

psibi commented Jun 22, 2023

Thanks @chrisdone-artificial! I have pushed a new release with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures with mtl-2.3
4 participants