Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checks #13

Merged
merged 2 commits into from
Feb 9, 2017
Merged

Fix checks #13

merged 2 commits into from
Feb 9, 2017

Conversation

AaronLasseigne
Copy link
Contributor

After a refactor, it looks like $argv was accidentally copied to a few places.

@AaronLasseigne AaronLasseigne mentioned this pull request Feb 8, 2017
Closed
@franciscolourenco
Copy link
Owner

Wow, surprising it worked for me. Could you please

  1. Can you rename the _initial_window_id to __done_initial_window_id for namespace purposes?
  2. Capitalise the commits titles. (sorry for the lack of contribution guide)

Thanks

@AaronLasseigne
Copy link
Contributor Author

Done

@skorokithakis skorokithakis mentioned this pull request Feb 9, 2017
Closed
@franciscolourenco franciscolourenco merged commit 4b227f5 into franciscolourenco:master Feb 9, 2017
@AaronLasseigne AaronLasseigne deleted the fix-checks branch February 9, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronLasseigne @franciscolourenco