Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fly 2 #1

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Support for Fly 2 #1

merged 2 commits into from
Mar 24, 2017

Conversation

otariidae
Copy link
Contributor

Changes:

  • Upgrade to the new syntax
  • Add try...catch and emit plugin_error
  • Improve a test with real Fly

@otariidae
Copy link
Contributor Author

oh... I forgot Destructuring assignment is not supported by Node v4 and v5.

By the way, Fly targets Node 6.x and some plugins no longer supports Node v5 or lower.

In my opinion, there are two ways:

  • Support Node v4 and v5
    or
  • Drop support for Node v5 or lower

Please tell me which to choose.

@frantic1048
Copy link
Owner

Thanks for your help!

According to discussion in wendux/fly#242 , I prefer targeting Node 6.x.

Another way, we can keep Node v4 and v5 until April as Fly's update. Which do you prefer?

@otariidae
Copy link
Contributor Author

@frantic1048 I prefer targeting Node v6 or later, too. 👍

@lukeed
Copy link

lukeed commented Feb 21, 2017

We've reverted to Node 4 because of LTS. I made the mistake of dropping it too early. However, as the plugin author, you may decide what's best.

@frantic1048 frantic1048 merged commit d2dee93 into frantic1048:master Mar 24, 2017
@frantic1048
Copy link
Owner

Sorry for the late, I forgot this issue for a time due to works in university. >_<
Thanks again for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants