Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--verbose flag is causing installation to fail #1223

Closed
ankush opened this issue Dec 3, 2021 · 0 comments · Fixed by #1243
Closed

--verbose flag is causing installation to fail #1223

ankush opened this issue Dec 3, 2021 · 0 comments · Fixed by #1243
Assignees
@ankush
Labels
bug

Comments

@ankush
Copy link
Member

ankush commented Dec 3, 2021 •
edited
Loading

https://github.com/frappe/ecommerce_integrations/runs/4407236017?check_suite_focus=true
https://github.com/frappe/ecommerce_integrations/pull/127/files

command:

bench --verbose --site test_site install-app ecommerce_integrations

Output:

Usage: bench [OPTIONS] COMMAND [ARGS]...
Try 'bench --help' for help.

Error: No such option: --site

edit: related to this change: 1b2bb87#diff-23971d78dc9c87535c1628bd472daff8d53fe2fc4cb56cc2b9c1537d4bfd4339R92
@ankush ankush added the bug label Dec 3, 2021
@ankush ankush self-assigned this Dec 3, 2021
@ankush ankush mentioned this issue Dec 17, 2021
Closed
@gavindsouza gavindsouza mentioned this issue Dec 20, 2021
Closed
gavindsouza added a commit to gavindsouza/bench that referenced this issue Dec 28, 2021
@gavindsouza
fix: Command picking & execution
6b3c929 
* Parse sys.argv appropriately and use them to match commands "better"
* Set bench.cli.verbose if --verbose is passed at any point in the
  command

Fixes frappe#1223, frappe#1224
gavindsouza added a commit to gavindsouza/bench that referenced this issue Dec 28, 2021
@gavindsouza
fix: Command picking & execution
2fa25d8 
Parse sys.argv appropriately and use them to match commands "better".
Using hacks to match with flags and options appear to be faulty, so
dropped that. Only matching with command names remains.

Fixes frappe#1223
@gavindsouza gavindsouza mentioned this issue Dec 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankush ankush

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Misc fixes gavindsouza/bench
1 participant
@ankush