Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--verbose flag doesn't apply to all steps in bench init #1224

Closed
vrslev opened this issue Dec 5, 2021 · 0 comments
Closed

--verbose flag doesn't apply to all steps in bench init #1224

vrslev opened this issue Dec 5, 2021 · 0 comments
Labels

Comments

@vrslev
Copy link

vrslev commented Dec 5, 2021

Describe the bug 📉

When running bench init with --verbose flag, --quiet flag is still being passed when creating virtualenv and upgrading pip. I truncated everything except commands executed by bench.

> bench init --frappe-branch version-13 --python python3.9 /tmp/testbench --verbose
$ /Users/lev/.pyenv/shims/virtualenv --quiet env -p python3.9
$ /private/tmp/testbench/env/bin/python -m pip install --quiet --upgrade pip
$ git clone https://github.com/frappe/frappe.git --branch version-13 --depth 1 --origin upstream
$ /private/tmp/testbench/env/bin/python -m pip install  --upgrade -e /private/tmp/testbench/apps/frappe 
$ yarn install
$ yarn run snyk-protect
$ snyk protect
$ FRAPPE_ENV=production node rollup/build.js --skip_frappe
SUCCESS: Bench testbench initialized

To Reproduce 📃

  1. Run bench init --frappe-branch version-13 --python python3.9 /tmp/testbench --verbose
  2. Notice that first two commands have --quiet flag but they shouldn't.

Expected behavior 📈
Verbose output of all subcommands if --verbose flag is passed.

Version Information

Can be found out by running bench version in your respective bench folder.

  • Bench Branch: 5.7.0
@vrslev vrslev added the bug label Dec 5, 2021
gavindsouza added a commit to gavindsouza/bench that referenced this issue Dec 28, 2021
* Parse sys.argv appropriately and use them to match commands "better"
* Set bench.cli.verbose if --verbose is passed at any point in the
  command

Fixes frappe#1223, frappe#1224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant