Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve regex to check if string is hex or rgb #275

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

Thunderbottom
Copy link
Contributor

use a different regex to check if passed string is a valid color by checking for both hex and rgb/hsl values. also, use a case-insensitive regex for checking hex colors.

fixes #274

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
@coveralls
Copy link

coveralls commented Mar 23, 2020

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%

Totals Coverage Status
Change from base Build 153: 0.0%
Covered Lines: 29
Relevant Lines: 62

💛 - Coveralls

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
@scmmishra scmmishra merged commit e95f0aa into frappe:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isValidColor failing on rgb() statements
3 participants