fix: reverse array when maxValue < absMinValue #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
approved these changes
Sep 16, 2020
|
Approved this PR, will make a release this weekend |
|
@silvestrevivo Thankyou sooo much for sorting this out. It's been driving me crazy for awhile and was extremely happy to see this update. Thankyou @scmmishra for all that you do. |
scmmishra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation About What Code Achieves:
When absMinValue is higher than the absMaxValue, the Y-axis is displayed reversed. This PR wants to fix that issue.
Screenshots/GIFs:
This is the initial state
This is after fixing the code: