fix: Adjust getColor to support RGB (TODO: HSL colors) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 13, 2020 15:45
- Add Test to verify changes
scmmishra
reviewed
Oct 23, 2020
There was a problem hiding this comment.
Hey @BartVanHoutte-ADING thanks for this fix. There are a few fixes in the test. I couldn't push them directly to this branch added a suggestion for it. Once you commit it, we can push the changes
|
@BartVanHoutte-ADING can you resolve the conflicts? |
|
@scmmishra Conflicts resolved. |
scmmishra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310