Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReactJS TypeError, Issue #323 #325

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Fix ReactJS TypeError, Issue #323 #325

merged 3 commits into from
Mar 10, 2021

Conversation

raibtoffoletto
Copy link
Contributor

Explanation About What Code Achieves:

src/js/utils/animation.js Outdated Show resolved Hide resolved
src/js/utils/animation.js Outdated Show resolved Hide resolved
@scmmishra scmmishra merged commit dadecb2 into frappe:master Mar 10, 2021
@scmmishra
Copy link
Contributor

hey @raibtoffoletto thanks for the fix. Can you backport this to v2-beta branch?

@raibtoffoletto
Copy link
Contributor Author

Hi @scmmishra, sorry my delay in replying, I'm glad do help. Will create a pr for the v2-beta =D

(ps: I don't know why my JS formatter didn't take care of the spacing).

@raibtoffoletto
Copy link
Contributor Author

ps2: It seems it's already on the beta branch, thanks for that. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants