Even after keeping the Quality Inspection Settings under the Stock Settings-Action If Quality Inspection Is Not Submitted- As Warn, but it still does not allow the GRN/Purchase receipt to get submit. It prevents the same

[JitendraSAW]

Information about bug

Dear Team,

We have a scenario where the QC has been enabled for our RM Item but we need to do the GRN so that the goods should get inward into the Warehouse and the system should only warn for the QC not done, but presently it is completing stopping to submit the Purchase Receipt/GRN even though Quality Inspection Settings- Action If Quality Inspection Is Not Submitted has kept as - As Warn.

Step:1-
See the Below Quality Inspection Settings

Record 1 Purchase Receipt

Even after submitting the same Purchase Receipt, It throws the error as below. It does not get submitted though after doing the above settings.

In the previous version of 13, it was working fine but the same is not working in the present releases also.

Module

quality

Version

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

![image](https://user-images.githubusercontent.com/80260184/166663013-8a6af128-e401-43f7-9191-0e3b82689cab.png)

[ankush]

This one is coming from

erpnext/erpnext/controllers/stock_controller.py

Lines 467 to 474 in c4d20ce

	def validate_qi_presence(self, row):
	"""Check if QI is present on row level. Warn on save and stop on submit if missing."""
	if not row.quality_inspection:
	msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}"
	if self.docstatus == 1:
	frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError)
	else:
	frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue")

This hasn't changed in nearly a year

[ankush]

@JitendraSAW this is from item config.

[ankush]

There are two different validations.

1. Whether the inspection is added against it or not (controlled by item level config)
2. Whether the inspection is submitted or not and whether to block resubmitted inspection (from stock settings)

I think both can be controlled in same manner using stock settings for warn/stop.

cc: @marination

[JitendraSAW]

Yes, You can test yourself, Earlier if we keep the Settings as If Quality Inspection Is Not Submitted- As Warn, then it was allowing you to submit the Purchase Receipt, but now it is not allowing you can check the very earlier version of 13.1 or 13.5 Thanks & Regards, Jitendra Gurejani

…

On Wed, May 4, 2022 at 3:50 PM Ankush Menat ***@***.***> wrote: are you sure this is recent breakage? This code hasn't changed since last year https://github.com/frappe/erpnext/blob/c4d20ce15969e14fdecf952b97fd4a8f20fbc71b/erpnext/controllers/stock_controller.py#L476-L491 — Reply to this email directly, view it on GitHub <#30895 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATEKYWGOW4B77FV5ZD2G6BDVIJFOVANCNFSM5VBP2GMQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- <https://www.sawindia.com/> Jitendra Gurejani ERP Implementation Consultant ***@***.*** (India) Pvt.Ltd CIO Review India - Company of the year 2020 | Tally Certified 5 Star Partner <https://www.sawindia.com/> T :4612 4444 | 7303030000 | M: 9167760418 | W: www.sawindia.com Santacruz (E), Mumbai | 400055 <https://www.facebook.com/sawindia> <https://www.linkedin.com/company/13316471/admin/> <https://www.youtube.com/channel/UCx_ViL8HIMKiyj32BQIVRJg>

[JitendraSAW]

I have just checked in the Version [image: image.png] [image: image.png] Now when record the GRN, or Purchase Receipt It throws the Message for 1 Time at the Draft Stage [image: image.png] But when we submit the same , it allows to submit and provide 1 Message again [image: image.png] You can see the below it got submitted and just through the Validation message again [image: image.png]

…

On Wed, May 4, 2022 at 4:01 PM Ankush Menat ***@***.***> wrote: There are two different validations. 1. Whether the inspection is added against it or not (controlled by item level config) 2. Whether the inspection is submitted or not and whether to block resubmitted inspection (from stock settings) I think both can be controlled in same manner using stock settings for warn/stop. cc: @marination <https://github.com/marination> — Reply to this email directly, view it on GitHub <#30895 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATEKYWCO3TOYPE3GWDBQH73VIJGZRANCNFSM5VBP2GMQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- <https://www.sawindia.com/> Jitendra Gurejani ERP Implementation Consultant ***@***.*** (India) Pvt.Ltd CIO Review India - Company of the year 2020 | Tally Certified 5 Star Partner <https://www.sawindia.com/> T :4612 4444 | 7303030000 | M: 9167760418 | W: www.sawindia.com Santacruz (E), Mumbai | 400055 <https://www.facebook.com/sawindia> <https://www.linkedin.com/company/13316471/admin/> <https://www.youtube.com/channel/UCx_ViL8HIMKiyj32BQIVRJg>