Add Taxes and Charges in Stock Entry material Transfer

[andiyan1]

Hi All,

I am proposing to add Taxes and Charges inside the Stock Entry - Material Transfer Document.

As We usually do Internal transfer of "product" from warehouse A in City A to Warehouse B to City B.
We would like to add cost of Transfer such as Shipping cost inside the product valuation. So it would be extremely helpful if stock entry- material transfer document has Taxes and Charges tab which we could add additional cost during transfer process.

Thanks
Anton

[rmehta]

Anton, good to hear from you. @nabinhait can you make a list of changes needed.

[nabinhait]

• Add Taxes and Charges tables (Re-use Landed Cost Taxes and Charges)
  • Description
  • Amount
• Distribute charges in all rows where there is target warehouse
• Validate/hide based on purpose
• Consider charges in item valuation and post in Stock Ledger Entry
• In case of perpetual inventory, post GL Entry
  • Expense Included in Valuation (Cr)
  • Warehouse Account (Dr)
• Remove existing "Additional Operating Cost" and merge with tax table.

[nabinhait]

Estimate is 4 billable hours

[andiyan1]

Yes please send me the estimate and if this improvement can be pushed in
the next release?

Thanks
Anton
On Jul 10, 2015 8:09 PM, "Nabin Hait" notifications@github.com wrote:

Estimate is 4 billable hours

—
Reply to this email directly or view it on GitHub
#3613 (comment).

[nabinhait]

@andiyan1 Will send the invoice on Monday.

[andiyan1]

Dear Sir,

I have received your invoice and paid already
Thanks and best wishes

Anton

[nabinhait]

@andiyan1 Thanks for the payment. We will try to complete the development as soon as possible.

[nabinhait]

@andiyan1

We are also cleaning up stock entry code (removing sales/purchase return option) while adding tax table. Thats why we are getting late to implement the tax feature in stock entry. Will keep you updated about the progress.

[andiyan1]

hi nabin,,

Thanks for the info.
Just take your time, by the way, if you remove sales/purchase return, where
are you going to place the sales/purchase return document?

thanks

Anton

On Thu, Jul 16, 2015 at 4:45 PM, Nabin Hait notifications@github.com
wrote:

@andiyan1 https://github.com/andiyan1

We are also cleaning up stock entry code (removing sales/purchase return
option) while adding tax table. Thats why we are getting late to implement
the tax feature in stock entry. Will keep you updated about the progress.

—
Reply to this email directly or view it on GitHub
#3613 (comment).

[nabinhait]

Sales/purchase return will be handled via Sales /Purchase Invoice with negative qty. In that way, you will be able to add tax details in sales/purchase return, which is currently not possible.

[andiyan1]

Nabin,

As far as i know, this create problem in your inventory valuation:

I had accounting software that did the same, and what i get is a bunch of
problems in inventory valuation.

here is what goes wrong in the old system:

1. they combine the amount debited from the customer and the amount
   deducted from inventory in the same journal. thus when they make
   sales/invoice return they amount of inventory valuation goes wrong.

2. example i sold 100 lamp for 12 dollars and 1 month later my customer
   return 10 of the lamp worth of 12 dollars.
   what i would make is a debit note to supplier worth of 10 lamps
   valuation at 12 dollars, thus making journal entry of 120 dollars credited
   from
   the customer receivable and add 120 dollars to my inventory valuation.

   the problem is: that on that day my inventory is not worth of 12
   dollars anymore, it might worth at 14.5 because of recent increase in
   valuation.(moving average system) thus creating an wrong /changed valuation
   in the stock entry. thus in the old system i always have problem with that.

PS: in the old system its not common for me to find item that has wrong
valuation lets say 1 lamp that worth 100 dollars in Inventory valuation
because of my customer returned the goods at lower price than valuation
thus in the system the valuation still the same but the quantity decreased
thus it showed larger cost value than what they should have.

What i like from ERPNEXT: you separate the stock return and supplier
invoice return. I LOVE THAT. so the stock return in valuation don't have
any effect on my customer receivable position. thus enabling me to return
the stock at the current average value (no effect on stock valuation) and
then enabling me to credit my customer receivable with his previous stock
return value. that is awesome!!.

my suggestion:
​please keep this separation. I Love this. I suggest you can still return
the material in quantity in the stock entry document, but then you can
deduct the customer invoice using purchase invoice rather than account
journal, I agree to this. this is what i do, therefore you can still
deduct the invoice taxes and charges and so on to the customer. but this
won't have problem with your warehouse valuation system. this is wha_t i
Propose._
and this is i think the best solution. as for your info. this is also what
erpnext can do but other system can't:

To make things worse: on some other system, sales return require you to
scroll back to old delivery note to customer and return the item from there
so you will get good stock valuation.

*on real life: *customer collect all the broken items in one big batch and
shipped it together in one single shipment, sometimes can have 100
(hundreds) different small items which has different delivery notes each.
in that old system my employee always complaint that they don't know which
delivery note to deduct because of customer did not retain the delivery
document - -so we don't know which one to deduct and which one to retain.
as they also don't want the hassle to separate item based on their previous
buying document.

What makes erpnext different than the others are: that no matters the
item valuation, you always return the goods at present value to warehouse
(no change in valuation of inventory) then after all item is accounted for,
the warehouse simply make debit note (journal voucher) to customer thus
deducting their total invoice value ( no problem with the present un-billed
sales invoice). thats what i like. that also happened the same with
purchase.

so Nabin, that is my opinion.

Please correct me if I'm wrong.

thanks and best regards

Anton

[nabinhait]

In the new system, you should be able to handle sales return from Delivery Note / Sales Invoice. So, if your warehouse guy want to execute stock return part, they can do that easily, making negative delivery note against original DN. And the system will pick original purchase/valuation rate of returned items based on FIFO or moving average. It will not be returned with sales rate, so no scope of error in the item valuation. If you want to skip Delivery Note, you can also return stock from negative invoice with "Update Stock" options checked.

And for credit note, you can make negative invoice against original invoice.

And regarding return in a lot, you must have to enter it against it's original DN, because the system require the original Deliver note to determine actual purchase rate of that item.

Same with purchase cycle.

[andiyan1]

Thats what im afraid.

I dont have the original DN. What if they returned me 1 containers worth of
stock and without proper document. I cant look up one stock by one and to
put it negative through dn if indont know which dn they deduct me.

Can you leave return system as it is and add the functionality also. So
dont remove the option for sales/purchase return in stock entry documet.
Other improvement in delivery/purchase receipt retuemrn is okay and idont
mind. What do you think?

So this will leave other user like me who do bulk return.

On Jul 20, 2015 1:11 PM, "Nabin Hait" notifications@github.com wrote:

In the new system, you should be able to handle sales return from Delivery
Note / Sales Invoice. So, if your warehouse guy want to execute stock
return part, they can do that easily, making negative delivery note against
original DN. And the system will pick original purchase/valuation rate of
returned items based on FIFO or moving average. It will not be returned
with sales rate, so no scope of error in the item valuation. If you want to
skip Delivery Note, you can also return stock from negative invoice with
"Update Stock" options checked.

And for credit note, you can make negative invoice against original
invoice.

And regarding return in a lot, you must have to enter it against it's
original DN, because the system require the original Deliver note to
determine actual purchase rate of that item.

Same with purchase cycle.

—
Reply to this email directly or view it on GitHub
#3613 (comment).

[nabinhait]

@andiyan1 I believe, what you are asking is not possible in current system as well. In Stock Entry (Return) form, you have to mention original DN / SI and it does not accept more than original qty as well.

[andiyan1]

Hi Nabin,

Sorry for late reply, I just checked with my colleague about the
modifications, yes we did some modification for the stock entry for the
return entry.
I believe the current workflow has worked well on my company and it has
worked quite well on the new system.

For the new modification, i am supportive with new modification as long as
it is for better system and better performance.

Thank you for your patient understanding and explanation on the new system.
If possible could you leave the stock return/purchase return option on the
stock entry for now, in addition also to add option to return document
through purchase receipt and delivery note negative stock entry.

Thanks again and wish you all best regards for the team.

Anton

PS: If you can not, then feel free to change it as you see fit. We are open
to new ideas as long as it is for better cause and for community.

On Mon, Jul 20, 2015 at 1:26 PM, Nabin Hait notifications@github.com
wrote:

@andiyan1 https://github.com/andiyan1 I believe, what you are asking is
not possible in current system as well. In Stock Entry (Return) form, you
have to mention original DN / SI and it does not accept more than original
qty as well.

—
Reply to this email directly or view it on GitHub
#3613 (comment).

[nabinhait]

@andiyan1 Today I have completed the return functionality. We hope it will better system than the existing one. We have removed the return option from Stock Entry. There is no point to maintain 2 set of code for the same functionality, as it not only increases maintenance effort, also confuse new users. The feature will be released within 1-2 days, hope you will love it. It is so straight forward.

By the way, today I am working on tax feature in stock entry, will keep you updated.

[andiyan1]

Yes I will be happy to look forward on the tax and return feature.

Thanks and best regards,

Anton

On Thu, Jul 23, 2015 at 4:22 PM, Nabin Hait notifications@github.com
wrote:

@andiyan1 https://github.com/andiyan1 Today I have completed the return
functionality. We hope it will better system than the existing one. We have
removed the return option from Stock Entry. There is no point to maintain 2
set of code for the same functionality, as it not only increases
maintenance effort, also confuse new users. The feature will be released
within 1-2 days, hope you will love it. It is so straight forward.

By the way, today I am working on tax feature in stock entry, will keep
you updated.

—
Reply to this email directly or view it on GitHub
#3613 (comment).

[nabinhait]

@andiyan1 Implemented main logic part for tax table in stock entry. Test case and manual updation is pending.

[andiyan1]

Thanks for the update Nabin, I am looking forward for that,

By the way the return system is looking great and straightforward. I Like it too.

Thanks for your work and patience

Anton

[nabinhait]

#3823

[andiyan1]

Dear Nabin,

The enhancement is working nicely, thanks for your support.
Another improvement that i can think of is to add service item as charges.
so rather than to add charges manually, we can preconfigure 1 service item that we can select as charges.

lets say we can preconfigure a transport fee by default so when we input charges we can just select that service item.

What do you think.

Thanks again.
Anton