Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Test] Tests for payment entry against purchase invoice #10834

Closed
wants to merge 1 commit into from
Closed

[UI Test] Tests for payment entry against purchase invoice #10834

wants to merge 1 commit into from

Conversation

utkarsh-goswami
Copy link
Contributor

#10668
Tests to check if the invoice number is correctly mapped in payment entry.

@utkarsh-goswami utkarsh-goswami changed the title Tests for payment entry against purchase invoice [UI Test] Tests for payment entry against purchase invoice Sep 18, 2017
nabinhait
nabinhait requested changes Sep 21, 2017
View reviewed changes
erpnext/accounts/doctype/payment_entry/tests/test_payment_against_purchase_invoice.js
() => {
assert.equal(cur_frm.doc.party, 'Test Supplier',
'supplier set in payment entry');
assert.equal(cur_frm.doc.paid_amount, 590,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paid_amount can be anything, it depends on outstanding purchase invoices. If we add/edit some test cases which changes outstanding amount of purchase invoices, it will fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to rewrite this like https://github.com/frappe/erpnext/blob/develop/erpnext/accounts/doctype/payment_entry/tests/test_payment_against_invoice.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabinhait Okay.

@nabinhait
Copy link
Member

Closing, check comments.

@nabinhait nabinhait closed this Sep 21, 2017
@utkarsh-goswami
Copy link
Contributor Author

@nabinhait
Test for purchase invoice is already done. So can't I use this purchase invoice to test the payment entry?
https://github.com/frappe/erpnext/blob/develop/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.js
Or should I write a test to make a independent purchase invoice and then test a payment entry of it?
I thought as if a test of purchase invoice is already created then I can use it in any other test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait requested changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utkarsh-goswami @nabinhait