Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow PI creation without PO #20864

Merged
merged 7 commits into from Apr 6, 2020

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Mar 6, 2020

  • Allow to create a Purchase Invoice against a supplier even though Purchase Order Required is set as "Yes" in Buying Settings
  • Checkboxes added in Customer and Supplier

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it only for allowing PI without PO?
The same thing is required for PR without PO, DN without SO and SI without SO.

throw(_("""Purchase Order Required for item {0}
To submit the invoice without purchase order please set
{1} as {2} in {3}""").format(frappe.bold(d.item_code), frappe.bold(_('Purchase Order Required')),
frappe.bold('No'), get_link_to_form('Buying Settings', 'Buying Settings', 'Buying Settings')))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_link_to_form ('Buying Settings', 'Buying Settings') works too

@Ponyooooo
Copy link

Is it possible if we could also include this feature on the Items? Because sometimes there are suppliers with mixed items which means the item can be received or items are for billing only. Also, if possible to have a checkbox on the item record if it will be included in the printing of the transactions so that it will be automatically not included on the print but still be included or visible on the transaction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants