fix: Allow PR/DN without PO/SO if set in Supplier/Customer Master #22514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows creation of Purchase Receipt without Purchase Order if "Allow Purchase Invoice Creation Without Purchase Order" in the Supplier Master is ticked. The same also applies for the corresponding option in Customer Master.
marination
reviewed
Jul 10, 2020
| @@ -118,6 +118,9 @@ def validate_with_previous_doc(self): | |||
|
|
|||
| def po_required(self): | |||
| if frappe.db.get_value("Buying Settings", None, "po_required") == 'Yes': | |||
| if frappe.get_value('Supplier', self.supplier, 'allow_purchase_invoice_creation_without_purchase_order'): | |||
There was a problem hiding this comment.
the checkbox clearly states that it affects Purchase Invoice, so, we only check this on Purchase Invoice or Sales Invoice validation. This just adds more unexplained behaviour which is unnecessary. Let's make the checkboxes function as per their labels.
|
@P-Froggy as mentioned in the review, the checkbox Allow Purchase Invoice Creation Without Purchase Order should affect only Purchase Invoice as mentioned in it's label. |
|
Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows creation of Purchase Receipt without Purchase Order if "Allow Purchase Invoice Creation Without Purchase Order" in the Supplier Master is ticked.
The same also applies for the corresponding option in Customer Master.
Details
PR #20864 added the option to overwrite the default behaviour of requiring a Purchase Order or a Sales Order for the creation of an Invoice based on the Supplier/Customer. However, this new logic has only been implemented in Purchase/Sales Invoice, but not in Purchase Receipt and Delivery Note.
Because the procurement process in ERPNext is Purchase Order -> Purchase Receipt -> Purchase Invoice this logic should also apply for Purchase Receipt and Delivery Note.