Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow PR/DN without PO/SO if set in Supplier/Customer Master #22513

Closed
wants to merge 1 commit into from
Closed

fix: Allow PR/DN without PO/SO if set in Supplier/Customer Master #22513

wants to merge 1 commit into from

Conversation

P-Froggy
Copy link
Contributor

Description

Allows creation of Purchase Receipt without Purchase Order if "Allow Purchase Invoice Creation Without Purchase Order" in the Supplier Master is ticked.
The same also applies for the corresponding option in Customer Master.

Details

PR #20864 added the option to overwrite the default behaviour of requiring a Purchase Order or a Sales Order for the creation of an Invoice based on the Supplier/Customer. However, this new logic has only been implemented in Purchase/Sales Invoice, but not in Purchase Receipt and Delivery Note.
Because the procurement process in ERPNext is Purchase Order -> Purchase Receipt -> Purchase Invoice this logic should also apply for Purchase Receipt and Delivery Note.

Proposal

I know this is not a discussion forum, but I thought of doing a cleanup of the Buying and Selling Settings. The addition of a per supplier and per customer based requisition of PO, PR, SO and DN made the options in Buying and Selling Settings redundant. These option fields could easily be removed and instead, only the fields in Supplier and Customer Master could be used. This way you only need to check one field instead of two during creation of PR, PI, DN and SI.
Maybe the reviewer of this PR could share his/her opinion on this.

Allows creation of Purchase Receipt without Purchase Order if "Allow Purchase Invoice Creation Without Purchase Order" in the Supplier Master is ticked.
The same also applies for the corresponding option in Customer Master.
@marination
Copy link
Collaborator

@P-Froggy Left a review on #22514. Your point of concern is valid we will tweak the options to incorporate Purchase Receipt and Delivery Note too. Thanks !!!

I know this is not a discussion forum, but I thought of doing a cleanup of the Buying and Selling Settings. The addition of a per supplier and per customer based requisition of PO, PR, SO and DN made the options in Buying and Selling Settings redundant. These option fields could easily be removed and instead, only the fields in Supplier and Customer Master could be used. This way you only need to check one field instead of two during creation of PR, PI, DN and SI.
Maybe the reviewer of this PR could share his/her opinion on this.

Regarding this, the use case as i currently see it is that, a majority of the users function via Buying/Selling settings itself and the options in it. The additional checkboxes in Customer / Supplier only affect that particular entity, but globally options in the Settings are applied.
It would be rather better for us to set the option once globally ("PO Required") and then based on certain suppliers or customers check "Allow Purchase Invoice Creation Without Purchase Order" only for that entity. So that I don't have to set the option for each and every supplier/customer.
However if your entire business process requires bypassing Purchase Order , you can again set po_required to No in Buying Settings.

@marination marination closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants