fix: Allow PR/DN without PO/SO if set in Supplier/Customer Master #22513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows creation of Purchase Receipt without Purchase Order if "Allow Purchase Invoice Creation Without Purchase Order" in the Supplier Master is ticked.
The same also applies for the corresponding option in Customer Master.
Details
PR #20864 added the option to overwrite the default behaviour of requiring a Purchase Order or a Sales Order for the creation of an Invoice based on the Supplier/Customer. However, this new logic has only been implemented in Purchase/Sales Invoice, but not in Purchase Receipt and Delivery Note.
Because the procurement process in ERPNext is Purchase Order -> Purchase Receipt -> Purchase Invoice this logic should also apply for Purchase Receipt and Delivery Note.
Proposal
I know this is not a discussion forum, but I thought of doing a cleanup of the Buying and Selling Settings. The addition of a per supplier and per customer based requisition of PO, PR, SO and DN made the options in Buying and Selling Settings redundant. These option fields could easily be removed and instead, only the fields in Supplier and Customer Master could be used. This way you only need to check one field instead of two during creation of PR, PI, DN and SI.
Maybe the reviewer of this PR could share his/her opinion on this.