Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revenue and Customer Count only in date range in Customer Acq. Report #22210

Merged
merged 6 commits into from
Jun 18, 2020
Merged

fix: Revenue and Customer Count only in date range in Customer Acq. Report #22210

merged 6 commits into from
Jun 18, 2020

Conversation

abhishekbalam
Copy link
Contributor

@abhishekbalam abhishekbalam commented Jun 12, 2020

Improvement on this:
#22075

The revenue was being calculated from
the 1st invoice ever created, and hence
is too high.

Also territorywise customer counts were wrong,
for the same reason, as monthly compensates for
report From Date by default.

So limiting counting of customers and revenue
within filter dates but considering all invoices
till To Date to determine new customers.

@abhishekbalam abhishekbalam changed the title fix: Limit revenue sum within date range of report in Customer Acq. Report fix: Revenue and Customer Count only in date range in Customer Acq. Report Jun 12, 2020
@abhishekbalam
Copy link
Contributor Author

Changes only done in the last function, had to
convert spaces to tabs as I didn't have the last
PR branch. From Line 162...

@deepeshgarg007
Copy link
Member

@abhishekbalam can you resolve merge conflicts

@deepeshgarg007 deepeshgarg007 self-assigned this Jun 14, 2020
@abhishekbalam
Copy link
Contributor Author

@deepeshgarg007
Done, please check.
If possible pls run locally and see if the report looks fine 👍

@deepeshgarg007 deepeshgarg007 merged commit 8db89bf into frappe:develop Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants