Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capture advance payments in payment order #23256

Merged
merged 5 commits into from
Sep 8, 2020
Merged

fix: capture advance payments in payment order #23256

merged 5 commits into from
Sep 8, 2020

Conversation

Mangesh-Khairnar
Copy link
Contributor

@Mangesh-Khairnar Mangesh-Khairnar commented Sep 4, 2020 •
edited
Loading

  • Issue: Currently, advance payments are not fetched in payment entry, payment order that is suppose to be submitted as a report for payments should have all these details too. Also, if payment order shouldn't split a single payment entry into multiple invoices.
  • Proposed Fix: Fetch a single entry in payment order reference against a payment entry with amount equal to paid amount.
    Kapture 2020-09-04 at 12 22 43

@rohitwaghchaure rohitwaghchaure self-assigned this Sep 4, 2020
@rohitwaghchaure rohitwaghchaure added the needs-tests This PR needs automated unit-tests. label Sep 4, 2020
@Mangesh-Khairnar Mangesh-Khairnar removed the needs-tests This PR needs automated unit-tests. label Sep 4, 2020
@rohitwaghchaure rohitwaghchaure merged commit 0cb8053 into frappe:develop Sep 8, 2020
@rohitwaghchaure rohitwaghchaure mentioned this pull request Nov 5, 2020
Merged
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees

@rohitwaghchaure rohitwaghchaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mangesh-Khairnar @rohitwaghchaure