fix: for Tree Type item and item group show net amout #31776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryPaulo
requested review from
nextchamp-saqib,
deepeshgarg007 and
ruthra-kumar
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #31776 +/- ##
===========================================
+ Coverage 63.25% 63.33% +0.07%
===========================================
Files 813 813
Lines 57520 57519 -1
===========================================
+ Hits 36386 36430 +44
+ Misses 21134 21089 -45
|
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
deepeshgarg007
pushed a commit
that referenced
this pull request
Apr 14, 2023
fix: for Tree Type item and item group show net amout (cherry picked from commit 9176209) Co-authored-by: hrzzz <paulo_fabris@hotmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-04-19) ### Bug Fixes * Add offers info to website item ([#34873](#34873)) ([f1a1fc6](f1a1fc6)) * Advance payment against payment terms ([#34872](#34872)) ([7461239](7461239)) * change discuss forum url ([#34891](#34891)) ([8f26d62](8f26d62)) * don't show disabled warehouses in the Warehouse Wise Stock Balance report ([461780d](461780d)) * Don't use stale item details ([#34847](#34847)) ([c11aeba](c11aeba)) * for Tree Type item and item group show net amount ([#31776](#31776)) ([7c8194a](7c8194a)) * linters issues ([c53dc06](c53dc06)) * Remove unnecessary checkbox from Accounts doctype ([#34821](#34821)) ([0cf6144](0cf6144)) * selling workspace is not migrating properly ([79fd38c](79fd38c)) * stock reco test case ([2f356dc](2f356dc)) * too many writes error while making backdated stock reconciliation ([a981b79](a981b79)) * unable to change `company` for manual `Serial No` entry ([2e7043c](2e7043c)) * **ux:** don't throw error when company defaults aren't set ([#34825](#34825)) ([15f5e8d](15f5e8d)) * whitelist doc method ([09b92fd](09b92fd)) ### Features * add german sales tax template ([#34823](#34823)) ([3738ea5](3738ea5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I place a Sales Order, let's assume my product costs $100, I sell 5 units, but I give $100 off, applying the discount in the "Additional Discount Amount" field.
Total products: $500
Additional Discount Amount: - $100
Net Amout: $400
Report: Sales Analytics
Tree Type = (Item, Item Group)
When I use the grouping by item or Item Group, the system is showing the sold value of the products, ex: $500, but the correct one must be $400, you must use the "base_net_amount" field to get the account in this report.
It doesn't make sense for me to open the Gross Profit report to view "$400" of sales and open the sales analytics respecting the groups informed above and the system display the value "$500".