Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add offers info to website item #34873

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 15, 2023

Screenshot 2023-04-15 at 7 45 50 PM

image

All checks passing now

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 15, 2023
@deepeshgarg007 deepeshgarg007 marked this pull request as draft April 15, 2023 14:16
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #34873 (88b598e) into develop (7fabe62) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

❗ Current head 88b598e differs from pull request most recent head da74d81. Consider uploading reports for the commit da74d81 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34873      +/-   ##
===========================================
- Coverage    63.87%   63.86%   -0.01%     
===========================================
  Files          810      810              
  Lines        59722    59715       -7     
===========================================
- Hits         38146    38137       -9     
- Misses       21576    21578       +2     
Impacted Files Coverage Δ
...xt/e_commerce/doctype/website_item/website_item.py 47.36% <16.66%> (-0.57%) ⬇️

... and 4 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review April 17, 2023 09:37
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Apr 17, 2023
@deepeshgarg007 deepeshgarg007 merged commit 534ea5a into frappe:develop Apr 17, 2023
mergify bot pushed a commit that referenced this pull request Apr 17, 2023
* fix: Add offers info to website item

* Revert "fix: Add offers info to website item"

This reverts commit 88b598e.

* fix: Add offer properties to website item

(cherry picked from commit 534ea5a)
deepeshgarg007 added a commit that referenced this pull request Apr 18, 2023
fix: Add offers info to website item (#34873)

* fix: Add offers info to website item

* Revert "fix: Add offers info to website item"

This reverts commit 88b598e.

* fix: Add offer properties to website item

(cherry picked from commit 534ea5a)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Apr 19, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-04-19)

### Bug Fixes

* Add offers info to website item ([#34873](#34873)) ([f1a1fc6](f1a1fc6))
* Advance payment against payment terms ([#34872](#34872)) ([7461239](7461239))
* change discuss forum url ([#34891](#34891)) ([8f26d62](8f26d62))
* don't show disabled warehouses in the Warehouse Wise Stock Balance report ([461780d](461780d))
* Don't use stale item details ([#34847](#34847)) ([c11aeba](c11aeba))
* for Tree Type item and item group show net amount ([#31776](#31776)) ([7c8194a](7c8194a))
* linters issues ([c53dc06](c53dc06))
* Remove unnecessary checkbox from Accounts doctype ([#34821](#34821)) ([0cf6144](0cf6144))
* selling workspace is not migrating properly ([79fd38c](79fd38c))
* stock reco test case ([2f356dc](2f356dc))
* too many writes error while making backdated stock reconciliation ([a981b79](a981b79))
* unable to change `company` for manual `Serial No` entry ([2e7043c](2e7043c))
* **ux:** don't throw error when company defaults aren't set ([#34825](#34825)) ([15f5e8d](15f5e8d))
* whitelist doc method ([09b92fd](09b92fd))

### Features

* add german sales tax template ([#34823](#34823)) ([3738ea5](3738ea5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant