Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use stale item details #34847

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

deepeshgarg007
Copy link
Member

Partially reverts changes in #34600

Fixes: #34835

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #34847 (22aadfd) into develop (7fabe62) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34847      +/-   ##
===========================================
- Coverage    63.87%   63.86%   -0.01%     
===========================================
  Files          810      810              
  Lines        59722    59714       -8     
===========================================
- Hits         38146    38137       -9     
- Misses       21576    21577       +1     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.15% <100.00%> (-0.04%) ⬇️
erpnext/stock/get_item_details.py 81.16% <100.00%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit a7051cb into frappe:develop Apr 14, 2023
mergify bot pushed a commit that referenced this pull request Apr 14, 2023
deepeshgarg007 added a commit that referenced this pull request Apr 14, 2023
fix: Don't use stale item details (#34847)

(cherry picked from commit a7051cb)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Apr 19, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-04-19)

### Bug Fixes

* Add offers info to website item ([#34873](#34873)) ([f1a1fc6](f1a1fc6))
* Advance payment against payment terms ([#34872](#34872)) ([7461239](7461239))
* change discuss forum url ([#34891](#34891)) ([8f26d62](8f26d62))
* don't show disabled warehouses in the Warehouse Wise Stock Balance report ([461780d](461780d))
* Don't use stale item details ([#34847](#34847)) ([c11aeba](c11aeba))
* for Tree Type item and item group show net amount ([#31776](#31776)) ([7c8194a](7c8194a))
* linters issues ([c53dc06](c53dc06))
* Remove unnecessary checkbox from Accounts doctype ([#34821](#34821)) ([0cf6144](0cf6144))
* selling workspace is not migrating properly ([79fd38c](79fd38c))
* stock reco test case ([2f356dc](2f356dc))
* too many writes error while making backdated stock reconciliation ([a981b79](a981b79))
* unable to change `company` for manual `Serial No` entry ([2e7043c](2e7043c))
* **ux:** don't throw error when company defaults aren't set ([#34825](#34825)) ([15f5e8d](15f5e8d))
* whitelist doc method ([09b92fd](09b92fd))

### Features

* add german sales tax template ([#34823](#34823)) ([3738ea5](3738ea5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Total Net Weight Calculating in Purchase order.
1 participant