fix: default pos conversion factor set to 1 #34437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shram007
requested review from
nextchamp-saqib,
deepeshgarg007 and
ruthra-kumar
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
(cherry picked from commit 08fc686) # Conflicts: # erpnext/selling/page/point_of_sale/point_of_sale.py
deepeshgarg007
added a commit
that referenced
this pull request
Mar 24, 2023
* fix: default pos conversion factor set to 1 (#34437) (cherry picked from commit 08fc686) # Conflicts: # erpnext/selling/page/point_of_sale/point_of_sale.py * chore: Resolve conflicts --------- Co-authored-by: Shram Kadia <65490105+Shram007@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
# [14.20.0](v14.19.0...v14.20.0) (2023-03-28) ### Bug Fixes * default pos conversion factor set to 1 ([#34437](#34437)) ([18d813a](18d813a)) * don't get zero value entries for exchange rate calculation ([#34475](#34475)) ([ff24b3e](ff24b3e)) * incorrect `Opening Value` in `Stock Balance` report ([76b782a](76b782a)) * Note username overlapping with note content(CRM) ([096e5ef](096e5ef)) * Party Name in SOA print when viewed from Customer/Supplier master ([#34597](#34597)) ([835edbe](835edbe)) * Percentage billing in Sales Order ([#34606](#34606)) ([477cb12](477cb12)) * recalculate WDV rate after asset repair [v14] ([#34571](#34571)) ([d2ca6f8](d2ca6f8)) * remove unused translation ([#34519](#34519)) ([881e92e](881e92e)) * removing redundant validation ([fd6db41](fd6db41)) * Sales person variance report without item group ([#34552](#34552)) ([90ddc4a](90ddc4a)) * Tax Category not able to set hence it calculating zero tax for item whoes tax template set ([#34525](#34525)) ([a8567b0](a8567b0)) * Time button not working in the job card ([8fed33b](8fed33b)) * translations and UX in alternative item mapping ([#34433](#34433)) ([702d07e](702d07e)) * unset address and contact on trash (backport [#34495](#34495)) ([#34560](#34560)) ([db01bf5](db01bf5)) * zero rm-cost for batch rm item in SCR (backport [#34616](#34616)) ([#34623](#34623)) ([cff35d7](cff35d7)) ### Features * deprecate get_customer_list ([#34563](#34563)) ([67576ad](67576ad))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #33005:
item.get("conversion factor")returned None type.Fix:
item.get("conversion factor").