Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused translation #34519

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 20, 2023

This string doesn't exist anymore. And if it did, it would probably belong to frappe, not erpnext.

@barredterra barredterra changed the title fix: remove wrong translation fix: remove unused translation Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #34519 (94202a8) into develop (ca10e2b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34519      +/-   ##
===========================================
- Coverage    63.88%   63.87%   -0.01%     
===========================================
  Files          810      810              
  Lines        59535    59536       +1     
===========================================
- Hits         38032    38031       -1     
- Misses       21503    21505       +2     

see 2 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Mar 21, 2023
@deepeshgarg007 deepeshgarg007 merged commit 0df3a1a into frappe:develop Mar 21, 2023
@barredterra barredterra deleted the signup-translation branch March 21, 2023 10:49
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
(cherry picked from commit 0df3a1a)

# Conflicts:
#	erpnext/translations/tr.csv
deepeshgarg007 pushed a commit that referenced this pull request Mar 22, 2023
* fix: remove unused translation (#34519)

(cherry picked from commit 0df3a1a)

# Conflicts:
#	erpnext/translations/tr.csv

* chore: resolve conflicts

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Mar 28, 2023
# [14.20.0](v14.19.0...v14.20.0) (2023-03-28)

### Bug Fixes

* default pos conversion factor set to 1 ([#34437](#34437)) ([18d813a](18d813a))
* don't get zero value entries for exchange rate calculation ([#34475](#34475)) ([ff24b3e](ff24b3e))
* incorrect `Opening Value` in `Stock Balance` report ([76b782a](76b782a))
* Note username overlapping with note content(CRM) ([096e5ef](096e5ef))
* Party Name in SOA print when viewed from Customer/Supplier master ([#34597](#34597)) ([835edbe](835edbe))
* Percentage billing in Sales Order ([#34606](#34606)) ([477cb12](477cb12))
* recalculate WDV rate after asset repair [v14] ([#34571](#34571)) ([d2ca6f8](d2ca6f8))
* remove unused translation ([#34519](#34519)) ([881e92e](881e92e))
* removing redundant validation ([fd6db41](fd6db41))
* Sales person variance report without item group ([#34552](#34552)) ([90ddc4a](90ddc4a))
* Tax Category not able to set hence it calculating zero tax for item whoes tax template set ([#34525](#34525)) ([a8567b0](a8567b0))
* Time button not working in the job card ([8fed33b](8fed33b))
* translations and UX in alternative item mapping ([#34433](#34433)) ([702d07e](702d07e))
* unset address and contact on trash (backport [#34495](#34495)) ([#34560](#34560)) ([db01bf5](db01bf5))
* zero rm-cost for batch rm item in SCR (backport [#34616](#34616)) ([#34623](#34623)) ([cff35d7](cff35d7))

### Features

* deprecate get_customer_list ([#34563](#34563)) ([67576ad](67576ad))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants