fix: don't get zero value entries for exchange rate calculation

[dj12djdjs]

App Versions

{
	"erpnext": "14.0.0-dev",
	"frappe": "15.0.0-dev"
}

Route

Form/Exchange Rate Revaluation/new-exchange-rate-revaluation-1

Trackeback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 56, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 53, in handle
    return _RESTAPIHandler(call, doctype, name).get_response()
  File "apps/frappe/frappe/api.py", line 69, in get_response
    return self.handle_method()
  File "apps/frappe/frappe/api.py", line 79, in handle_method
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 48, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 86, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1589, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/handler.py", line 307, in run_doc_method
    response = doc.run_method(method)
  File "apps/frappe/frappe/model/document.py", line 922, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1276, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1258, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 919, in fn
    return method_object(*args, **kwargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 33, in wrapper
    return func(*args, **kwargs)
  File "apps/erpnext/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py", line 96, in get_accounts_data
    accounts_with_new_balance = self.calculate_new_account_balance(
  File "apps/erpnext/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py", line 230, in calculate_new_account_balance
    current_exchange_rate * d.balance_in_account_currency
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'

Request Data

{
	"type": "POST",
	"args": {
		"docs": "{\"docstatus\":0,\"doctype\":\"Exchange Rate Revaluation\",\"name\":\"new-exchange-rate-revaluation-1\",\"__islocal\":1,\"__unsaved\":1,\"owner\":\"ds@partsupinc.com\",\"posting_date\":\"2023-03-16\",\"company\":\"PPS Premium Part Supply Inc.\",\"accounts\":[{\"docstatus\":0,\"doctype\":\"Exchange Rate Revaluation Account\",\"name\":\"new-exchange-rate-revaluation-account-1\",\"__islocal\":1,\"__unsaved\":1,\"owner\":\"ds@partsupinc.com\",\"account_currency\":\"CAD\",\"zero_balance\":0,\"parent\":\"new-exchange-rate-revaluation-1\",\"parentfield\":\"accounts\",\"parenttype\":\"Exchange Rate Revaluation\",\"idx\":1}]}",
		"method": "get_accounts_data"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/run_doc_method"
}

Response Data

{
	"exception": "TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'"
}

[codecov]

Codecov Report

Merging #34475 (1e96ffb) into develop (2942cee) will decrease coverage by 0.25%.
The diff coverage is 83.96%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #34475      +/-   ##
===========================================
- Coverage    64.09%   63.84%   -0.25%     
===========================================
  Files          810      810              
  Lines        59372    59495     +123     
===========================================
- Hits         38052    37987      -65     
- Misses       21320    21508     +188     

Impacted Files	Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py	0.00% <0.00%> (ø)
...ext/accounts/report/trial_balance/trial_balance.py	0.00% <0.00%> (ø)
erpnext/hooks.py	100.00% <ø> (ø)
...facturing/doctype/bom_update_log/bom_update_log.py	42.60% <0.00%> (-44.12%)	⬇️
...ext/manufacturing/doctype/work_order/work_order.py	80.88% <0.00%> (-0.28%)	⬇️
...stock/doctype/item_alternative/item_alternative.py	0.00% <0.00%> (ø)
erpnext/www/book_appointment/index.py	0.00% <0.00%> (ø)
erpnext/manufacturing/doctype/bom/bom.py	75.15% <33.33%> (-12.94%)	⬇️
erpnext/controllers/website_list_for_contact.py	53.54% <42.85%> (+0.05%)	⬆️
erpnext/utilities/doctype/video/video.py	23.07% <50.00%> (+0.85%)	⬆️
... and 20 more

... and 5 files with indirect coverage changes