Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates in process statement of Accounts #35064

Merged
merged 1 commit into from
May 1, 2023
Merged

fix: Updates in process statement of Accounts #35064

merged 1 commit into from
May 1, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 26, 2023 •
edited
Loading

  • Sender email account in process statement of Accounts
  • Use customer id as well in case the customer name is different than the customer id (primary key)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #35064 (55dde46) into develop (dd238aa) will decrease coverage by 0.19%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35064      +/-   ##
===========================================
- Coverage    63.87%   63.69%   -0.19%     
===========================================
  Files          810      813       +3     
  Lines        59746    60019     +273     
===========================================
+ Hits         38163    38228      +65     
- Misses       21583    21791     +208
Impacted Files Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py 0.00% <ø> (ø)

... and 29 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label May 1, 2023
@deepeshgarg007 deepeshgarg007 merged commit ea0b03a into frappe:develop May 1, 2023
mergify bot pushed a commit that referenced this pull request May 1, 2023
@deepeshgarg007 @mergify
fix: Updates in process statement of Accounts (#35064)
26c7810 
(cherry picked from commit ea0b03a)

# Conflicts:
#	erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json
@mergify mergify bot mentioned this pull request May 1, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request May 2, 2023
@mergify @deepeshgarg007
fix: Updates in process statement of Accounts (#35064)
bef9dd7 
* fix: Updates in process statement of Accounts (#35064)

(cherry picked from commit ea0b03a)

# Conflicts:
#	erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json

* chore: resolve conflicts

---------

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 3, 2023
@frappe-bot
chore(release): Bumped to Version 14.23.1
5eb5bf7 
## [14.23.1](v14.23.0...v14.23.1) (2023-05-03)

### Bug Fixes

* conflicts ([3ba2b9e](3ba2b9e))
* don't allow to make reposting for the closed period ([cca2fce](cca2fce))
* don't create material request from sales order against the delivered items ([a5489ee](a5489ee))
* handle expected_value_after_useful_life properly in asset value adjustment ([#35117](#35117)) ([80230fe](80230fe))
* handle finance book properly in trial balance and general ledger [v14] ([#35136](#35136)) ([344c339](344c339))
* Hyperlink in Quality Inspection Summary ([e4ce6fa](e4ce6fa))
* incorrect paid_amount and exchange rate in PE ([f50b4d8](f50b4d8))
* linter issue ([78c34d7](78c34d7))
* linter issue ([453249d](453249d))
* Naming series error in Journal Entry template ([#35084](#35084)) ([7021e3a](7021e3a))
* not able to create delivery note from sales order ([28dfc13](28dfc13))
* Report link, option, and added a link for Sales Person in GP ([fc611cf](fc611cf))
* test case ([35ec125](35ec125))
* test case ([6597c74](6597c74))
* test case ([d844a2b](d844a2b))
* timeout error while submitting delivery note ([e33fb3b](e33fb3b))
* Updates in process statement of Accounts ([#35064](#35064)) ([bef9dd7](bef9dd7))
@commit-lint commit-lint bot mentioned this pull request Jun 7, 2023
Merged
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deepeshgarg007