Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Naming series error in Journal Entry template #35084

Merged
merged 1 commit into from
May 1, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 27, 2023

Naming series should not get reset on every refresh, only onload when the form is still not saved and primary key is not generated

@deepeshgarg007 deepeshgarg007 merged commit f3b3dab into frappe:develop May 1, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request May 1, 2023
mergify bot pushed a commit that referenced this pull request May 1, 2023
deepeshgarg007 added a commit that referenced this pull request May 1, 2023
fix: Naming series error in Journal Entry template (#35084)

(cherry picked from commit f3b3dab)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
deepeshgarg007 added a commit that referenced this pull request May 1, 2023
fix: Naming series error in Journal Entry template (#35084)

(cherry picked from commit f3b3dab)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 3, 2023
## [14.23.1](v14.23.0...v14.23.1) (2023-05-03)

### Bug Fixes

* conflicts ([3ba2b9e](3ba2b9e))
* don't allow to make reposting for the closed period ([cca2fce](cca2fce))
* don't create material request from sales order against the delivered items ([a5489ee](a5489ee))
* handle expected_value_after_useful_life properly in asset value adjustment ([#35117](#35117)) ([80230fe](80230fe))
* handle finance book properly in trial balance and general ledger [v14] ([#35136](#35136)) ([344c339](344c339))
* Hyperlink in Quality Inspection Summary ([e4ce6fa](e4ce6fa))
* incorrect paid_amount and exchange rate in PE ([f50b4d8](f50b4d8))
* linter issue ([78c34d7](78c34d7))
* linter issue ([453249d](453249d))
* Naming series error in Journal Entry template ([#35084](#35084)) ([7021e3a](7021e3a))
* not able to create delivery note from sales order ([28dfc13](28dfc13))
* Report link, option, and added a link for Sales Person in GP ([fc611cf](fc611cf))
* test case ([35ec125](35ec125))
* test case ([6597c74](6597c74))
* test case ([d844a2b](d844a2b))
* timeout error while submitting delivery note ([e33fb3b](e33fb3b))
* Updates in process statement of Accounts ([#35064](#35064)) ([bef9dd7](bef9dd7))
frappe-pr-bot pushed a commit that referenced this pull request May 3, 2023
# [13.50.0](v13.49.14...v13.50.0) (2023-05-03)

### Bug Fixes

* allow user to set standard deductions in income tax slab without allowing other exemptions ([c5261cd](c5261cd))
* check for session user rather than owner ([7d6e2f9](7d6e2f9))
* conflicts ([778ba69](778ba69))
* conflicts ([b19b0a4](b19b0a4))
* conflicts ([6bdf143](6bdf143))
* don't allow to make reposting for the closed period ([b31d8ee](b31d8ee))
* handle expected_value_after_useful_life properly in asset value adjustment (backport [#35117](#35117)) ([#35120](#35120)) ([635559d](635559d))
* handle finance book properly in trial balance and general ledger ([#35136](#35136)) ([9a37603](9a37603))
* Hyperlink in Quality Inspection Summary ([54388e8](54388e8))
* Naming series error in Journal Entry template ([#35084](#35084)) ([d3c769c](d3c769c))
* per_billed condition for Payment Entry ([#34969](#34969)) ([563e5c0](563e5c0))
* test case ([db6d0e0](db6d0e0))

### Features

* validate repost item valuation against accounts freeze date ([a852dc1](a852dc1))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant