fix: handle expected_value_after_useful_life properly in asset value adjustment #35117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
added
backport version-13-hotfix
backport develop
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 3, 2023
## [14.23.1](v14.23.0...v14.23.1) (2023-05-03) ### Bug Fixes * conflicts ([3ba2b9e](3ba2b9e)) * don't allow to make reposting for the closed period ([cca2fce](cca2fce)) * don't create material request from sales order against the delivered items ([a5489ee](a5489ee)) * handle expected_value_after_useful_life properly in asset value adjustment ([#35117](#35117)) ([80230fe](80230fe)) * handle finance book properly in trial balance and general ledger [v14] ([#35136](#35136)) ([344c339](344c339)) * Hyperlink in Quality Inspection Summary ([e4ce6fa](e4ce6fa)) * incorrect paid_amount and exchange rate in PE ([f50b4d8](f50b4d8)) * linter issue ([78c34d7](78c34d7)) * linter issue ([453249d](453249d)) * Naming series error in Journal Entry template ([#35084](#35084)) ([7021e3a](7021e3a)) * not able to create delivery note from sales order ([28dfc13](28dfc13)) * Report link, option, and added a link for Sales Person in GP ([fc611cf](fc611cf)) * test case ([35ec125](35ec125)) * test case ([6597c74](6597c74)) * test case ([d844a2b](d844a2b)) * timeout error while submitting delivery note ([e33fb3b](e33fb3b)) * Updates in process statement of Accounts ([#35064](#35064)) ([bef9dd7](bef9dd7))
|
🎉 This PR is included in version 14.23.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 3, 2023
# [13.50.0](v13.49.14...v13.50.0) (2023-05-03) ### Bug Fixes * allow user to set standard deductions in income tax slab without allowing other exemptions ([c5261cd](c5261cd)) * check for session user rather than owner ([7d6e2f9](7d6e2f9)) * conflicts ([778ba69](778ba69)) * conflicts ([b19b0a4](b19b0a4)) * conflicts ([6bdf143](6bdf143)) * don't allow to make reposting for the closed period ([b31d8ee](b31d8ee)) * handle expected_value_after_useful_life properly in asset value adjustment (backport [#35117](#35117)) ([#35120](#35120)) ([635559d](635559d)) * handle finance book properly in trial balance and general ledger ([#35136](#35136)) ([9a37603](9a37603)) * Hyperlink in Quality Inspection Summary ([54388e8](54388e8)) * Naming series error in Journal Entry template ([#35084](#35084)) ([d3c769c](d3c769c)) * per_billed condition for Payment Entry ([#34969](#34969)) ([563e5c0](563e5c0)) * test case ([db6d0e0](db6d0e0)) ### Features * validate repost item valuation against accounts freeze date ([a852dc1](a852dc1))
|
Hi @anandbaburajan @deepeshgarg007 Thanks a lot for this fix but the entire schedule on the Asset is wrong... not only after adjustment Reference: #34920 Pls take a look if possible... could be the same issue affecting both Many thanks |
|
Hi @Olawale1, I missed to see the issue you opened. Will take a look, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset Value Adjustment creates wrong depreciation schedule for assets with expected_value_after_useful_life, so fixed that.