Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pricing rule rounding #41288

Merged
merged 2 commits into from
May 7, 2024

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented May 2, 2024

Consider a pricing rule of 20:1 with Recursion and Round Free Qty enabled, free item qty should follow the below progression

Qty Free item qty
0-19 0
20-39 1
40-59 2

Consider a pricing rule of 20:1 with recursion enabled, free items
should follow the below progression

|   Qty | Free item qty |
|-------+---------------|
|  0-19 |             0 |
| 20-39 |             1 |
| 40-59 |             2 |
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 2, 2024
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 7, 2024
@ruthra-kumar ruthra-kumar merged commit c50663c into frappe:develop May 7, 2024
13 checks passed
ruthra-kumar added a commit that referenced this pull request May 7, 2024
…-41288

fix: pricing rule rounding (backport #41288)
ruthra-kumar added a commit that referenced this pull request May 7, 2024
…-41288

fix: pricing rule rounding (backport #41288)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant