Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SO, DN): only show permitted actions #41384

Merged
merged 2 commits into from
May 13, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented May 8, 2024

Assume we have a user whose only permission is to read Sales Orders. We shouldn't display all the "Update Items" and "Create ..." buttons, because clicking them will just result in an error message and a frustrating user experience.

Before

All actions are available, regardless of permissions.

Bildschirmfoto 2024-05-08 um 16 21 10

After

Only permitted actions are displayed (none, in this case).

Bildschirmfoto 2024-05-08 um 16 20 45

The same applies to Delivery Note.

@barredterra barredterra changed the title fix(Sales Order): only show permitted actions fix(SO, DN): only show permitted actions May 8, 2024
@barredterra barredterra merged commit 6433337 into frappe:develop May 13, 2024
13 checks passed
@barredterra barredterra deleted the sales-order-actions branch May 13, 2024 13:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant