fix: TypeError when msgprint() receives lists #19255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
|
@Ahuahuachi can you share the error and example of message that causes the error? edit: nvm, it's there on issue you created: #19253 |
ankush
changed the title
ankush
approved these changes
Dec 13, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
# [14.19.0](v14.18.1...v14.19.0) (2022-12-13) ### Bug Fixes * allow changing counter for prefix-less series ([#19180](#19180)) ([#19190](#19190)) ([a2a91bb](a2a91bb)) * child table not working ([e1b231a](e1b231a)) * do not rename select field options and values on doctype rename ([#19223](#19223)) ([#19226](#19226)) ([f511dfc](f511dfc)) * **docshare:** return None if share_name and value are None ([#19187](#19187)) ([#19189](#19189)) ([b8541e9](b8541e9)) * log unknown usernames too for failed attempts ([#19199](#19199)) ([#19201](#19201)) ([6db0b8a](6db0b8a)) * only make fetch_from field read only if no input ([#19192](#19192)) ([#19195](#19195)) ([17e8aa5](17e8aa5)) * reload shared dialog upon checking any perm ([#19196](#19196)) ([#19198](#19198)) ([cfa6ec2](cfa6ec2)) * set-config -g ([#19217](#19217)) ([#19219](#19219)) ([2fd7af7](2fd7af7)) * stabilize shared with dialog ([#19186](#19186)) ([c013d11](c013d11)) * TypeError when using frappe.throw() or frappe.msgprint() with lists ([#19255](#19255)) ([#19256](#19256)) ([0748324](0748324)) * unscrub and translate field names in tooltip explaining fetch from (backport [#19143](#19143)) ([#19174](#19174)) ([018984e](018984e)) * untranslated link fields in list view ([#19155](#19155)) ([4296681](4296681)) * **UX:** forget password shows error on wrong email ([#19235](#19235)) ([#19240](#19240)) ([ac1ca50](ac1ca50)) * validate parentfield while checking child perms ([a9871b2](a9871b2)) * workflow icon not visible in mobile view ([388a919](388a919)) ### Features * allow user to pick all columns ([#19236](#19236)) ([16a1253](16a1253)) * finer frappe Recorder control with decorator ([#19220](#19220)) ([#19222](#19222)) ([4402f12](4402f12)) * inter-process file locks (backport [#19133](#19133)) ([#19142](#19142)) ([c407dae](c407dae)) ### Performance Improvements * remove order_by from linked_with checks ([#19229](#19229)) ([#19243](#19243)) ([3fa0207](3fa0207))
SaiFi0102
pushed a commit
to ParaLogicTech/frappe
that referenced
this pull request
Dec 16, 2022
…sts (frappe#19255) (frappe#19256) Co-authored-by: Alfredo Altamirano <Ahuahuachi@users.noreply.github.com> (cherry picked from commit ffe3ba1) Co-authored-by: Alfredo Altamirano <8353891+Ahuahuachi@users.noreply.github.com>
SaiFi0102
pushed a commit
to ParaLogicTech/frappe
that referenced
this pull request
Dec 16, 2022
# [14.19.0](frappe/frappe@v14.18.1...v14.19.0) (2022-12-13) ### Bug Fixes * allow changing counter for prefix-less series ([frappe#19180](frappe#19180)) ([frappe#19190](frappe#19190)) ([a2a91bb](frappe@a2a91bb)) * child table not working ([e1b231a](frappe@e1b231a)) * do not rename select field options and values on doctype rename ([frappe#19223](frappe#19223)) ([frappe#19226](frappe#19226)) ([f511dfc](frappe@f511dfc)) * **docshare:** return None if share_name and value are None ([frappe#19187](frappe#19187)) ([frappe#19189](frappe#19189)) ([b8541e9](frappe@b8541e9)) * log unknown usernames too for failed attempts ([frappe#19199](frappe#19199)) ([frappe#19201](frappe#19201)) ([6db0b8a](frappe@6db0b8a)) * only make fetch_from field read only if no input ([frappe#19192](frappe#19192)) ([frappe#19195](frappe#19195)) ([17e8aa5](frappe@17e8aa5)) * reload shared dialog upon checking any perm ([frappe#19196](frappe#19196)) ([frappe#19198](frappe#19198)) ([cfa6ec2](frappe@cfa6ec2)) * set-config -g ([frappe#19217](frappe#19217)) ([frappe#19219](frappe#19219)) ([2fd7af7](frappe@2fd7af7)) * stabilize shared with dialog ([frappe#19186](frappe#19186)) ([c013d11](frappe@c013d11)) * TypeError when using frappe.throw() or frappe.msgprint() with lists ([frappe#19255](frappe#19255)) ([frappe#19256](frappe#19256)) ([0748324](frappe@0748324)) * unscrub and translate field names in tooltip explaining fetch from (backport [frappe#19143](frappe#19143)) ([frappe#19174](frappe#19174)) ([018984e](frappe@018984e)) * untranslated link fields in list view ([frappe#19155](frappe#19155)) ([4296681](frappe@4296681)) * **UX:** forget password shows error on wrong email ([frappe#19235](frappe#19235)) ([frappe#19240](frappe#19240)) ([ac1ca50](frappe@ac1ca50)) * validate parentfield while checking child perms ([a9871b2](frappe@a9871b2)) * workflow icon not visible in mobile view ([388a919](frappe@388a919)) ### Features * allow user to pick all columns ([frappe#19236](frappe#19236)) ([16a1253](frappe@16a1253)) * finer frappe Recorder control with decorator ([frappe#19220](frappe#19220)) ([frappe#19222](frappe#19222)) ([4402f12](frappe@4402f12)) * inter-process file locks (backport [frappe#19133](frappe#19133)) ([frappe#19142](frappe#19142)) ([c407dae](frappe@c407dae)) ### Performance Improvements * remove order_by from linked_with checks ([frappe#19229](frappe#19229)) ([frappe#19243](frappe#19243)) ([3fa0207](frappe@3fa0207))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix, strips HTML tags for each message received in list by msgprint, avoiding a TypeError caused by the
_strip_html_tags()function